From: Akhil R <akhilrajeev@nvidia.com>
To: <andi.shyti@kernel.org>, <digetx@gmail.com>,
<jonathanh@nvidia.com>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<thierry.reding@gmail.com>, <wsa+renesas@sang-engineering.com>,
<wsa@kernel.org>
Cc: <kkartik@nvidia.com>, <akhilrajeev@nvidia.com>,
<ldewangan@nvidia.com>, <smangipudi@nvidia.com>
Subject: [PATCH v13 3/6] i2c: tegra: Update Tegra256 timing parameters
Date: Tue, 18 Nov 2025 19:36:17 +0530 [thread overview]
Message-ID: <20251118140620.549-4-akhilrajeev@nvidia.com> (raw)
In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com>
Update the timing parameters of Tegra256 so that the signals are complaint
with the I2C specification for SCL low time.
Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index c0382c9a0430..470d0d32d571 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1684,7 +1684,7 @@ static const struct tegra_i2c_hw_feature tegra256_i2c_hw = {
.clk_divisor_hs_mode = 7,
.clk_divisor_std_mode = 0x7a,
.clk_divisor_fast_mode = 0x40,
- .clk_divisor_fast_plus_mode = 0x19,
+ .clk_divisor_fast_plus_mode = 0x14,
.has_config_load_reg = true,
.has_multi_master_mode = true,
.has_slcg_override_reg = true,
@@ -1695,14 +1695,13 @@ static const struct tegra_i2c_hw_feature tegra256_i2c_hw = {
.has_apb_dma = false,
.tlow_std_mode = 0x8,
.thigh_std_mode = 0x7,
- .tlow_fast_mode = 0x3,
- .thigh_fast_mode = 0x3,
- .tlow_fastplus_mode = 0x3,
- .thigh_fastplus_mode = 0x3,
+ .tlow_fast_mode = 0x4,
+ .thigh_fast_mode = 0x2,
+ .tlow_fastplus_mode = 0x4,
+ .thigh_fastplus_mode = 0x4,
.setup_hold_time_std_mode = 0x08080808,
- .setup_hold_time_fast_mode = 0x02020202,
- .setup_hold_time_fastplus_mode = 0x02020202,
- .setup_hold_time_hs_mode = 0x090909,
+ .setup_hold_time_fast_mode = 0x04010101,
+ .setup_hold_time_fastplus_mode = 0x04020202,
.has_interface_timing_reg = true,
};
--
2.50.1
next prev parent reply other threads:[~2025-11-18 14:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 14:06 [PATCH v13 0/6] Updates for Tegra264 and Tegra256 Akhil R
2025-11-18 14:06 ` [PATCH v13 1/6] i2c: tegra: Do not configure DMA if not supported Akhil R
2025-11-27 9:29 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 2/6] i2c: tegra: Use separate variables for fast and fastplus Akhil R
2025-11-27 9:30 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` Akhil R [this message]
2025-11-27 9:31 ` [PATCH v13 3/6] i2c: tegra: Update Tegra256 timing parameters Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 4/6] i2c: tegra: Add HS mode support Akhil R
2025-11-18 14:19 ` Jon Hunter
2025-11-27 9:34 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 5/6] i2c: tegra: Add support for SW mutex register Akhil R
2025-11-27 9:36 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 6/6] i2c: tegra: Add Tegra264 support Akhil R
2025-11-27 9:36 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-27 9:37 ` [PATCH v13 0/6] Updates for Tegra264 and Tegra256 Thierry Reding
2025-12-19 9:09 ` Akhil R
2026-01-06 6:28 ` Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118140620.549-4-akhilrajeev@nvidia.com \
--to=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox