Re: [PATCH v2 1/2] usb: phy: tegra: use phy type directly

[kernel test robot <lkp@intel.com>]

Hi Svyatoslav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on usb/usb-testing usb/usb-next usb/usb-linus staging/staging-testing staging/staging-next staging/staging-linus drm-tegra/drm/tegra/for-next linus/master v6.19-rc2 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Svyatoslav-Ryhel/usb-phy-tegra-use-phy-type-directly/20251223-175449
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link:    https://lore.kernel.org/r/20251223094529.7202-2-clamor95%40gmail.com
patch subject: [PATCH v2 1/2] usb: phy: tegra: use phy type directly
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20251224/202512240627.LvJwMSta-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 4ef602d446057dabf5f61fb221669ecbeda49279)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251224/202512240627.LvJwMSta-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512240627.LvJwMSta-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/phy/phy-tegra-usb.c:853:2: warning: variable 'err' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
     853 |         default:
         |         ^~~~~~~
   drivers/usb/phy/phy-tegra-usb.c:857:6: note: uninitialized use occurs here
     857 |         if (err)
         |             ^~~
   drivers/usb/phy/phy-tegra-usb.c:839:9: note: initialize the variable 'err' to silence this warning
     839 |         int err;
         |                ^
         |                 = 0
   1 warning generated.


vim +/err +853 drivers/usb/phy/phy-tegra-usb.c

   836	
   837	static int tegra_usb_phy_power_off(struct tegra_usb_phy *phy)
   838	{
   839		int err;
   840	
   841		if (!phy->powered_on)
   842			return 0;
   843	
   844		switch (phy->phy_type) {
   845		case USBPHY_INTERFACE_MODE_UTMI:
   846			err = utmi_phy_power_off(phy);
   847			break;
   848	
   849		case USBPHY_INTERFACE_MODE_ULPI:
   850			err = ulpi_phy_power_off(phy);
   851			break;
   852	
 > 853		default:
   854			break;
   855		}
   856	
   857		if (err)
   858			return err;
   859	
   860		phy->powered_on = false;
   861	
   862		return 0;
   863	}
   864	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki