From: Prathamesh Shete <pshete@nvidia.com>
To: <linusw@kernel.org>, <brgl@kernel.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<linux-gpio@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <pshete@nvidia.com>
Subject: [PATCH v2 1/2] gpio: tegra186: Simplify GPIO line name prefix handling
Date: Tue, 17 Feb 2026 08:14:30 +0000 [thread overview]
Message-ID: <20260217081431.1208351-1-pshete@nvidia.com> (raw)
Introduce TEGRA_GPIO_PREFIX() to define the Tegra SoC GPIO name
prefix in one place. Use it for the Tegra410 COMPUTE and SYSTEM
controllers so the prefix is "COMPUTE-" and "SYSTEM-" respectively.
Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
---
Changes in v2:
* Split the v1 patch into two; this one to simplify prefix handling.
---
drivers/gpio/gpio-tegra186.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index 9c874f07be75..f04cc240b5ec 100644
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -942,12 +942,8 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
char *name;
for (j = 0; j < port->pins; j++) {
- if (gpio->soc->prefix)
- name = devm_kasprintf(gpio->gpio.parent, GFP_KERNEL, "%s-P%s.%02x",
- gpio->soc->prefix, port->name, j);
- else
- name = devm_kasprintf(gpio->gpio.parent, GFP_KERNEL, "P%s.%02x",
- port->name, j);
+ name = devm_kasprintf(gpio->gpio.parent, GFP_KERNEL, "%sP%s.%02x",
+ gpio->soc->prefix ?: "", port->name, j);
if (!name)
return -ENOMEM;
@@ -1373,6 +1369,9 @@ static const struct tegra_gpio_soc tegra256_main_soc = {
.has_vm_support = true,
};
+/* Macro to define GPIO name prefix with separator */
+#define TEGRA_GPIO_PREFIX(_x) _x "-"
+
#define TEGRA410_COMPUTE_GPIO_PORT(_name, _bank, _port, _pins) \
TEGRA_GPIO_PORT(TEGRA410_COMPUTE, _name, _bank, _port, _pins)
@@ -1388,7 +1387,7 @@ static const struct tegra_gpio_soc tegra410_compute_soc = {
.num_ports = ARRAY_SIZE(tegra410_compute_ports),
.ports = tegra410_compute_ports,
.name = "tegra410-gpio-compute",
- .prefix = "COMPUTE",
+ .prefix = TEGRA_GPIO_PREFIX("COMPUTE"),
.num_irqs_per_bank = 8,
.instance = 0,
};
@@ -1418,7 +1417,7 @@ static const struct tegra_gpio_soc tegra410_system_soc = {
.num_ports = ARRAY_SIZE(tegra410_system_ports),
.ports = tegra410_system_ports,
.name = "tegra410-gpio-system",
- .prefix = "SYSTEM",
+ .prefix = TEGRA_GPIO_PREFIX("SYSTEM"),
.num_irqs_per_bank = 8,
.instance = 0,
};
--
2.43.0
next reply other threads:[~2026-02-17 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 8:14 Prathamesh Shete [this message]
2026-02-17 8:14 ` [PATCH v2 2/2] gpio: tegra186: Support multi-socket devices Prathamesh Shete
2026-02-17 9:34 ` Jon Hunter
2026-02-17 10:06 ` Thierry Reding
2026-02-17 9:34 ` [PATCH v2 1/2] gpio: tegra186: Simplify GPIO line name prefix handling Jon Hunter
2026-02-17 10:04 ` Thierry Reding
2026-02-17 12:17 ` Bartosz Golaszewski
2026-02-17 13:29 ` Jon Hunter
2026-02-17 14:06 ` Bartosz Golaszewski
2026-02-23 9:57 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217081431.1208351-1-pshete@nvidia.com \
--to=pshete@nvidia.com \
--cc=brgl@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox