public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: <bhelgaas@google.com>, <lpieralisi@kernel.org>,
	<kwilczynski@kernel.org>, <mani@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<kishon@kernel.org>, <arnd@arndb.de>,
	<gregkh@linuxfoundation.org>, <Frank.Li@nxp.com>,
	<den@valinux.co.jp>, <hongxing.zhu@nxp.com>,
	<jingoohan1@gmail.com>, <vidyas@nvidia.com>, <cassel@kernel.org>,
	<18255117159@163.com>
Cc: <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Manikanta Maddireddy <mmaddireddy@nvidia.com>
Subject: [PATCH v7 13/13] PCI: tegra194: Free resources during controller deinitialization
Date: Tue, 3 Mar 2026 12:24:48 +0530	[thread overview]
Message-ID: <20260303065448.2361488-14-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com>

From: Vidya Sagar <vidyas@nvidia.com>

Call pci_epc_deinit_notify() during controller deinitialization to free the
resources allocated by Endpoint function driver. This is safe to call
during PCIe assert sequence because we don't expect Endpoint function
driver to touch hardware in deinit function.

Fixes: 40e2125381dc ("PCI: tegra194: Move controller cleanups to pex_ep_event_pex_rst_deassert()")
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
---
Changes V5 -> V7: None
Changes V4 -> V5: Remove pci_epc_deinit_notify() call from pex_ep_event_pex_rst_deassert()
Changes V1 -> V4: None

 drivers/pci/controller/dwc/pcie-tegra194.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index a311c31109e3..b1ae46761915 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -1624,12 +1624,16 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)
 
 static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie)
 {
+	struct dw_pcie *pci = &pcie->pci;
+	struct dw_pcie_ep *ep = &pci->ep;
 	u32 val;
 	int ret;
 
 	if (pcie->ep_state == EP_STATE_DISABLED)
 		return;
 
+	pci_epc_deinit_notify(ep->epc);
+
 	ret = readl_poll_timeout(pcie->appl_base + APPL_DEBUG, val,
 		((val & APPL_DEBUG_LTSSM_STATE_MASK) == LTSSM_STATE_DETECT_QUIET) ||
 		((val & APPL_DEBUG_LTSSM_STATE_MASK) == LTSSM_STATE_DETECT_ACT) ||
@@ -1796,7 +1800,6 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
 	reset_control_deassert(pcie->core_rst);
 
 	/* Perform cleanup that requires refclk and core reset deasserted */
-	pci_epc_deinit_notify(pcie->pci.ep.epc);
 	dw_pcie_ep_cleanup(&pcie->pci.ep);
 
 	val = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL);
-- 
2.34.1


  parent reply	other threads:[~2026-03-03  6:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  6:54 [PATCH v7 00/13] Fixes to pcie-tegra194 driver Manikanta Maddireddy
2026-03-03  6:54 ` [PATCH v7 01/13] PCI: tegra194: Fix polling delay for L2 state Manikanta Maddireddy
2026-03-03  6:54 ` [PATCH v7 02/13] PCI: tegra194: Refactor LTSSM state polling on surprise down Manikanta Maddireddy
2026-03-05  9:31   ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 03/13] PCI: tegra194: Don't force the device into the D0 state before L2 Manikanta Maddireddy
2026-03-05  9:40   ` Manivannan Sadhasivam
2026-03-15 13:21     ` Manikanta Maddireddy
2026-03-16  1:25       ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 04/13] PCI: tegra194: Disable PERST IRQ only in Endpoint mode Manikanta Maddireddy
2026-03-03  6:54 ` [PATCH v7 05/13] PCI: tegra194: Use devm_gpiod_get_optional() to parse "nvidia,refclk-select" Manikanta Maddireddy
2026-03-03  6:54 ` [PATCH v7 06/13] PCI: tegra194: Disable direct speed change for EP Manikanta Maddireddy
2026-03-05  9:43   ` Manivannan Sadhasivam
2026-03-15 13:44     ` Manikanta Maddireddy
2026-03-16  1:27       ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 07/13] PCI: tegra194: Set LTR message request before PCIe link up Manikanta Maddireddy
2026-03-05 10:18   ` Manivannan Sadhasivam
2026-03-15 13:49     ` Manikanta Maddireddy
2026-03-16  1:28       ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 08/13] PCI: tegra194: Apply pinctrl settings for both PCIe RP and EP Manikanta Maddireddy
2026-03-05 10:19   ` Manivannan Sadhasivam
2026-03-15 13:54     ` Manikanta Maddireddy
2026-03-16  1:31       ` Manivannan Sadhasivam
2026-03-16  3:41         ` Manikanta Maddireddy
2026-03-16  4:26           ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 09/13] PCI: tegra194: Allow system suspend when the Endpoint link is not up Manikanta Maddireddy
2026-03-05 10:29   ` Manivannan Sadhasivam
2026-03-15 14:10     ` Manikanta Maddireddy
2026-03-16  1:34       ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 10/13] PCI: tegra194: Free up EP resources during remove() Manikanta Maddireddy
2026-03-03  6:54 ` [PATCH v7 11/13] PCI: tegra194: Use HW version number Manikanta Maddireddy
2026-03-05 10:34   ` Manivannan Sadhasivam
2026-03-03  6:54 ` [PATCH v7 12/13] PCI: tegra194: Fix CBB timeout caused by DBI access before core power-on Manikanta Maddireddy
2026-03-03  6:54 ` Manikanta Maddireddy [this message]
2026-03-05 10:43   ` [PATCH v7 13/13] PCI: tegra194: Free resources during controller deinitialization Manivannan Sadhasivam
2026-03-15 14:16     ` Manikanta Maddireddy
2026-03-16  1:35       ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260303065448.2361488-14-mmaddireddy@nvidia.com \
    --to=mmaddireddy@nvidia.com \
    --cc=18255117159@163.com \
    --cc=Frank.Li@nxp.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=den@valinux.co.jp \
    --cc=gregkh@linuxfoundation.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=jingoohan1@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox