public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Sheetal <sheetal@nvidia.com>, Takashi Iwai <tiwai@suse.de>,
	Sasha Levin <sashal@kernel.org>,
	perex@perex.cz, tiwai@suse.com, thierry.reding@gmail.com,
	jonathanh@nvidia.com, linux-sound@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH AUTOSEL 6.19-6.18] ALSA: hda/hdmi: Add Tegra238 HDA codec device ID
Date: Tue, 10 Mar 2026 05:01:01 -0400	[thread overview]
Message-ID: <20260310090145.2709021-1-sashal@kernel.org> (raw)

From: Sheetal <sheetal@nvidia.com>

[ Upstream commit 5f4338e5633dc034a81000b2516a78cfb51c601d ]

Add Tegra238 HDA codec device in hda_device_id list.

Signed-off-by: Sheetal <sheetal@nvidia.com>
Link: https://patch.msgid.link/20260302084217.3135982-1-sheetal@nvidia.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

## Analysis: ALSA: hda/hdmi: Add Tegra238 HDA codec device ID

### Commit Overview
This is a single-line addition of a new HDA codec device ID
(`0x10de0032`) for the Tegra238 HDMI/DP audio codec to the existing
`snd_hda_id_tegrahdmi[]` device ID table.

### Classification: New Device ID Addition

This falls squarely into the **"New Device IDs"** exception category for
stable backports. The change:

1. Adds exactly one line: `HDA_CODEC_ID_MODEL(0x10de0032, "Tegra238
   HDMI/DP", MODEL_TEGRA234)`
2. Uses an existing model type (`MODEL_TEGRA234`) — the same model used
   by surrounding entries (Tegra234, SoC 33, Tegra264, SoC 35)
3. The driver already fully exists in stable trees
4. No new code paths, no new features, no behavioral changes for
   existing hardware

### Risk Assessment
- **Risk: Extremely low.** This is a data-only change — adding an entry
  to a device ID table. It cannot affect any existing hardware or code
  path.
- **Scope: Minimal.** One line in one file.
- **Regression potential: Near zero.** The new entry is only matched
  when the specific Tegra238 hardware is present.

### User Impact
Without this ID, users with Tegra238 SoCs would have no HDMI/DP audio
support. This is a real hardware enablement fix for NVIDIA's Tegra238
platform.

### Stable Kernel Rules Compliance
1. **Obviously correct and tested**: Yes — follows the exact same
   pattern as all other entries in the table, uses the same model as the
   adjacent Tegra234 entry.
2. **Fixes a real bug**: Yes — hardware doesn't work without its device
   ID in the table.
3. **Small and contained**: Yes — one line.
4. **No new features/APIs**: Correct — uses existing driver
   infrastructure.

### Verification
- Reviewed the diff: confirms a single `HDA_CODEC_ID_MODEL` line
  insertion using existing `MODEL_TEGRA234` model type, consistent with
  adjacent entries.
- The file `sound/hda/codecs/hdmi/tegrahdmi.c` contains the full Tegra
  HDMI codec driver with probe, init, build_pcms, etc. — the driver is
  complete and existing.
- The new entry is placed in numerical order between `0x10de0031`
  (Tegra234) and `0x10de0033` (SoC 33), both using `MODEL_TEGRA234`.
- Commit is signed off by NVIDIA engineer (sheetal@nvidia.com) and
  accepted by the ALSA maintainer (Takashi Iwai).

### Conclusion
This is a textbook device ID addition — the single most common and least
risky type of stable backport. It enables HDMI/DP audio on Tegra238
hardware with zero risk to existing functionality.

**YES**

 sound/hda/codecs/hdmi/tegrahdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/hdmi/tegrahdmi.c b/sound/hda/codecs/hdmi/tegrahdmi.c
index 5f6fe31aa2028..ebb6410a48313 100644
--- a/sound/hda/codecs/hdmi/tegrahdmi.c
+++ b/sound/hda/codecs/hdmi/tegrahdmi.c
@@ -299,6 +299,7 @@ static const struct hda_device_id snd_hda_id_tegrahdmi[] = {
 	HDA_CODEC_ID_MODEL(0x10de002f, "Tegra194 HDMI/DP2",	MODEL_TEGRA),
 	HDA_CODEC_ID_MODEL(0x10de0030, "Tegra194 HDMI/DP3",	MODEL_TEGRA),
 	HDA_CODEC_ID_MODEL(0x10de0031, "Tegra234 HDMI/DP",	MODEL_TEGRA234),
+	HDA_CODEC_ID_MODEL(0x10de0032, "Tegra238 HDMI/DP",	MODEL_TEGRA234),
 	HDA_CODEC_ID_MODEL(0x10de0033, "SoC 33 HDMI/DP",	MODEL_TEGRA234),
 	HDA_CODEC_ID_MODEL(0x10de0034, "Tegra264 HDMI/DP",	MODEL_TEGRA234),
 	HDA_CODEC_ID_MODEL(0x10de0035, "SoC 35 HDMI/DP",	MODEL_TEGRA234),
-- 
2.51.0


                 reply	other threads:[~2026-03-10  9:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260310090145.2709021-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=perex@perex.cz \
    --cc=sheetal@nvidia.com \
    --cc=stable@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox