From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7B93A3810 for ; Tue, 24 Mar 2026 18:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376853; cv=none; b=Cin8hoRskZ3VfN5K7XS8uN0Jq62BKQSwkiIf+7bb8F+krUa+JJr82aYkxzDFVPaAJAzebj4NNsu+ORI+r/7zCEmoIIk8Rx+y/3voA4Fum98NnbxH+10o3jG6xLkW7pPt2ozeSXOiOcKjlga+uZ12njkbLEAZF12XBj4aJgq2Vmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376853; c=relaxed/simple; bh=+c/3pLSCjN8W96sioUUAyB3Q4h2iU9EyKqZsQlwSrmM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uIaRuCDmICXS8P1G5WmkAOmEjdozIeQHVX5tZXe/XUsgzkEO3om1aNrMoCT3yL30sz84gRcCf92pYtFlYSDsPjl0N7aPpUpsMzBGTBjm/beCE8+RyHr5LisVl9XXB5c/XJGUH4d1vArUXi19aZLtQpwj8Nwv6mA6pJtFxouYZoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GC+or1ZB; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GC+or1ZB" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-358d80f60ccso907152a91.3 for ; Tue, 24 Mar 2026 11:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376852; x=1774981652; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9Gsg2Xtdfdl+8IY6r0o/RyYDfTlBlRsSZJpA/oULFGs=; b=GC+or1ZBszh9b/mDXpyH6YFSURr0Y7FWzKFYXJDiHRRqorLsJ662RFHGQO6Rh2nR8T oswnXCPH9ejMEIda9bLMUS6333IvfiZol2LGDVpZUTvoOlKIt/ifsA+VX1MDE9SJBerP Pz/dvsPKLzzLalpazat9fha9s/qqJ+HE2X1R3Ac32KjrOZqYUNAadRzu40i5FaJH7gEL RD+nDC6/ZIS/vlM3GAXn+ro61ShH5l17OLFsWgT8gbAzHMt5ve2ZPRoxaEnNEH1+FmOQ Tz0GkRr4brxK3jmxMYEBef1q3853H146BClaMsNTRhFsjT5P6bZINZ8q9ev5LG3UWAVN 6Shw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376852; x=1774981652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9Gsg2Xtdfdl+8IY6r0o/RyYDfTlBlRsSZJpA/oULFGs=; b=G4SktHQneahOrGKfCntRHm2OomeBhx2OZWMt25oYMLBraezCw1Tso1fcIyyNanyly2 5yG76w3WBbupiUpI2251y/8drVGw8Poj5ISUW6f+TExevvc3RgGWd5xosKp1HVmA3+cG XXMQ8vTotp+U1lPGtgAattMw+1bazjiN0bxtMmxM+j5bG7IsXMJp9sYY8LTy0Jdlb597 Wu6FFR1jTfJ+iWHaVP9dDfeAa608H9wToNilRaaJjbul5scmy2PYRJa7Fqw0BdL06B+K dw9nsWiXdK8eh2At3yDLqYZCSU6j1QADtEmnKUwoHCgpGRf1V0q2eC8DIBmIwWr3NGnO mp9g== X-Forwarded-Encrypted: i=1; AJvYcCU1ScMqswC97ZXUY/qtFCHg5uN90pS+e3eidQQ+VYkiyXCWhI3+JdpTT9KYNvnBXwv5RdmlFk9oC+FItA==@vger.kernel.org X-Gm-Message-State: AOJu0Yy2NXTJL3stYIaibmsLq9YIyG1NnpA7Y5cfn03URBt9GGMDjUbG hsSkFaiJisGe0zpszC5Ah8C1mUvB1ZGH3Wx/ZOl1KX05tlbbQGYdqcgr X-Gm-Gg: ATEYQzxDEJ2wgSUIBhxWrCK9kAlY9Kr6j504ILTEIAbSkipO8nWLibaV/hLytLflDNE UeBFL2HUn8rVysa61dSYhg4NLo1IGxEwymcSAwRKrJCM+/s+VkBEsdxRqm5An3f/4xYtyWX0gyM hOTODV7L34kHLlzn0uaHOskc8eGOVs3wnOFTw0x2Xp50TDQTYYk1s0bYU+dkJ2XdUhUWRMRdFsc aqQ7LBPtqNIjk2+fa7CzEmHlrz+22Gv4meJoECzMLujTeDAMZo0d7xsMlTFUlIHZViILedPE2NB e55eyCJXSobo0LkiLIDKdTyLLBeLR4brBI2oxFgqh7ihWYdsqTmZ7fhYR0IG1x16ZIyhlgFt1qg kxmj3v5/1N2EGzX+5wg0EiHQH0qHT6RXxN0XPvKLIHyVgLBJER7B8EdI7vvc+bNblw95g9tfhSU QnVp44mZSWYvspn7ibK6PusW2ObM9ZXlHBicta X-Received: by 2002:a17:90b:17c8:b0:35b:e591:99d1 with SMTP id 98e67ed59e1d1-35c0ddc4118mr351953a91.29.1774376851910; Tue, 24 Mar 2026 11:27:31 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:31 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:50 +0530 Subject: [PATCH 02/10] i2c: tegra: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260324-deverr-v1-2-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1910; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=T//TFybKN0iS3J929ONSQMLq+NVtMUv+4U4PajSEtpE=; b=fr2E/ILXide+l6/sGLPzjFEjto2BGT6qqnz9x0FPbuW7SDMBkCcBooGAF0nF3tgg5wQpoDzh0 nAnDJBBoQYcAomrkw15oBfCFd8unXKN1lYuv+oiXhwJuhidayGEmEVJ X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-tegra.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bec619b9af4e..51d15fca82fc 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -575,8 +575,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) dma_buf = dma_alloc_coherent(i2c_dev->dma_dev, i2c_dev->dma_buf_size, &dma_phys, GFP_KERNEL | __GFP_NOWARN); if (!dma_buf) { - dev_err(i2c_dev->dev, "failed to allocate DMA buffer\n"); - err = -ENOMEM; + err = dev_err_probe(i2c_dev->dev, -ENOMEM, + "failed to allocate DMA buffer\n"); goto err_out; } @@ -588,8 +588,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) err_out: tegra_i2c_release_dma(i2c_dev); if (err != -EPROBE_DEFER) { - dev_err(i2c_dev->dev, "cannot use DMA: %d\n", err); - dev_err(i2c_dev->dev, "falling back to PIO\n"); + dev_err_probe(i2c_dev->dev, err, + "cannot use DMA, falling back to PIO\n"); return 0; } @@ -1953,7 +1953,7 @@ static int tegra_i2c_init_clocks(struct tegra_i2c_dev *i2c_dev) err = clk_enable(i2c_dev->div_clk); if (err) { - dev_err(i2c_dev->dev, "failed to enable div-clk: %d\n", err); + dev_err_probe(i2c_dev->dev, err, "failed to enable div-clk\n"); goto unprepare_clocks; } @@ -1979,7 +1979,7 @@ static int tegra_i2c_init_hardware(struct tegra_i2c_dev *i2c_dev) ret = pm_runtime_get_sync(i2c_dev->dev); if (ret < 0) - dev_err(i2c_dev->dev, "runtime resume failed: %d\n", ret); + dev_err_probe(i2c_dev->dev, ret, "runtime resume failed\n"); else ret = tegra_i2c_init(i2c_dev); -- 2.43.0