From: Sheetal <sheetal@nvidia.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Mohan Kumar" <mkumard@nvidia.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
<linux-sound@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Sheetal <sheetal@nvidia.com>
Subject: [PATCH v3 09/14] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers
Date: Wed, 25 Mar 2026 10:14:32 +0000 [thread overview]
Message-ID: <20260325101437.3059693-10-sheetal@nvidia.com> (raw)
In-Reply-To: <20260325101437.3059693-1-sheetal@nvidia.com>
Log errors in the Tegra210 OPE, PEQ and MBDRC probe paths using
dev_err_probe().
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
sound/soc/tegra/tegra210_mbdrc.c | 10 +++++-----
sound/soc/tegra/tegra210_ope.c | 19 ++++++++-----------
sound/soc/tegra/tegra210_peq.c | 10 +++++-----
3 files changed, 18 insertions(+), 21 deletions(-)
diff --git a/sound/soc/tegra/tegra210_mbdrc.c b/sound/soc/tegra/tegra210_mbdrc.c
index 6a268dbb7197..558b7a21b0be 100644
--- a/sound/soc/tegra/tegra210_mbdrc.c
+++ b/sound/soc/tegra/tegra210_mbdrc.c
@@ -987,8 +987,9 @@ int tegra210_mbdrc_regmap_init(struct platform_device *pdev)
int err;
child = of_get_child_by_name(dev->of_node, "dynamic-range-compressor");
if (!child)
- return -ENODEV;
+ return dev_err_probe(dev, -ENODEV,
+ "missing 'dynamic-range-compressor' DT child node\n");
err = of_address_to_resource(child, 0, &mem);
of_node_put(child);
@@ -1004,7 +1005,6 @@ int tegra210_mbdrc_regmap_init(struct platform_device *pdev)
ope->mbdrc_regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_mbdrc_regmap_cfg);
- if (IS_ERR(ope->mbdrc_regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(ope->mbdrc_regmap);
- }
+ if (IS_ERR(ope->mbdrc_regmap))
+ return dev_err_probe(dev, PTR_ERR(ope->mbdrc_regmap),
+ "MBDRC regmap init failed\n");
diff --git a/sound/soc/tegra/tegra210_ope.c b/sound/soc/tegra/tegra210_ope.c
index a440888dcdbd..e311de41a078 100644
--- a/sound/soc/tegra/tegra210_ope.c
+++ b/sound/soc/tegra/tegra210_ope.c
@@ -329,23 +329,18 @@ static int tegra210_ope_probe(struct platform_device *pdev)
err = tegra210_peq_regmap_init(pdev);
- if (err < 0) {
- dev_err(dev, "PEQ init failed\n");
- return err;
- }
+ if (err < 0)
+ return dev_err_probe(dev, err, "PEQ init failed\n");
err = tegra210_mbdrc_regmap_init(pdev);
- if (err < 0) {
- dev_err(dev, "MBDRC init failed\n");
- return err;
- }
+ if (err < 0)
+ return dev_err_probe(dev, err, "MBDRC init failed\n");
err = devm_snd_soc_register_component(dev, &tegra210_ope_cmpnt,
tegra210_ope_dais,
ARRAY_SIZE(tegra210_ope_dais));
- if (err) {
- dev_err(dev, "can't register OPE component, err: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err,
+ "can't register OPE component\n");
pm_runtime_enable(dev);
diff --git a/sound/soc/tegra/tegra210_peq.c b/sound/soc/tegra/tegra210_peq.c
index 2f72e9d541dc..4b692c2055bc 100644
--- a/sound/soc/tegra/tegra210_peq.c
+++ b/sound/soc/tegra/tegra210_peq.c
@@ -407,8 +407,9 @@ int tegra210_peq_regmap_init(struct platform_device *pdev)
int err;
child = of_get_child_by_name(dev->of_node, "equalizer");
if (!child)
- return -ENODEV;
+ return dev_err_probe(dev, -ENODEV,
+ "missing 'equalizer' DT child node\n");
err = of_address_to_resource(child, 0, &mem);
of_node_put(child);
@@ -424,7 +425,6 @@ int tegra210_peq_regmap_init(struct platform_device *pdev)
ope->peq_regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_peq_regmap_config);
- if (IS_ERR(ope->peq_regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(ope->peq_regmap);
- }
+ if (IS_ERR(ope->peq_regmap))
+ return dev_err_probe(dev, PTR_ERR(ope->peq_regmap),
+ "PEQ regmap init failed\n");
--
2.17.1
next prev parent reply other threads:[~2026-03-25 10:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 10:14 [PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures Sheetal
2026-03-25 10:14 ` [PATCH v3 01/14] ASoC: tegra: Use dev_err_probe() in tegra186_asrc probe Sheetal
2026-03-25 13:03 ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 02/14] ASoC: tegra: Use dev_err_probe() in tegra186_dspk probe Sheetal
2026-03-25 10:14 ` [PATCH v3 03/14] ASoC: tegra: Add error logging in tegra210_admaif driver Sheetal
2026-03-25 13:05 ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 04/14] ASoC: tegra: Add error logging in tegra210_adx driver Sheetal
2026-03-25 10:14 ` [PATCH v3 05/14] ASoC: tegra: Use dev_err_probe() in tegra210_ahub probe Sheetal
2026-03-25 13:07 ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 06/14] ASoC: tegra: Add error logging in tegra210_amx driver Sheetal
2026-03-25 10:14 ` [PATCH v3 07/14] ASoC: tegra: Use dev_err_probe() in tegra210_dmic probe Sheetal
2026-03-25 13:08 ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 08/14] ASoC: tegra: Add error logging in tegra210_i2s driver Sheetal
2026-03-25 10:14 ` Sheetal [this message]
2026-03-25 13:10 ` [PATCH v3 09/14] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers Mark Brown
2026-03-25 10:14 ` [PATCH v3 10/14] ASoC: tegra: Use dev_err_probe() in tegra210_mixer probe Sheetal
2026-03-25 10:14 ` [PATCH v3 11/14] ASoC: tegra: Use dev_err_probe() in tegra210_mvc probe Sheetal
2026-03-25 10:14 ` [PATCH v3 12/14] ASoC: tegra: Use dev_err_probe() in tegra210_sfc probe Sheetal
2026-03-25 13:11 ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 13/14] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe Sheetal
2026-03-25 10:14 ` [PATCH v3 14/14] ASoC: tegra: Use dev_err_probe() in tegra_audio_graph_card probe Sheetal
2026-03-25 13:18 ` (subset) [PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325101437.3059693-10-sheetal@nvidia.com \
--to=sheetal@nvidia.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=thierry.reding@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox