public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Sheetal <sheetal@nvidia.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"Mohan Kumar" <mkumard@nvidia.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	<linux-sound@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Sheetal <sheetal@nvidia.com>
Subject: [PATCH v3 14/14] ASoC: tegra: Use dev_err_probe() in tegra_audio_graph_card probe
Date: Wed, 25 Mar 2026 10:14:37 +0000	[thread overview]
Message-ID: <20260325101437.3059693-15-sheetal@nvidia.com> (raw)
In-Reply-To: <20260325101437.3059693-1-sheetal@nvidia.com>

Log errors in the Tegra audio graph card probe path using
dev_err_probe().

Signed-off-by: Sheetal <sheetal@nvidia.com>
---
 sound/soc/tegra/tegra_audio_graph_card.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c
index ea10e6e8a9fe..b93a61db9ed0 100644
--- a/sound/soc/tegra/tegra_audio_graph_card.c
+++ b/sound/soc/tegra/tegra_audio_graph_card.c
@@ -174,20 +174,23 @@ static int tegra_audio_graph_card_probe(struct snd_soc_card *card)
 {
 	struct simple_util_priv *simple = snd_soc_card_get_drvdata(card);
 	struct tegra_audio_priv *priv = simple_to_tegra_priv(simple);
+	int ret;
 
 	priv->clk_plla = devm_clk_get(card->dev, "pll_a");
-	if (IS_ERR(priv->clk_plla)) {
-		dev_err(card->dev, "Can't retrieve clk pll_a\n");
-		return PTR_ERR(priv->clk_plla);
-	}
+	if (IS_ERR(priv->clk_plla))
+		return dev_err_probe(card->dev, PTR_ERR(priv->clk_plla),
+				     "can't retrieve clk pll_a\n");
 
 	priv->clk_plla_out0 = devm_clk_get(card->dev, "plla_out0");
-	if (IS_ERR(priv->clk_plla_out0)) {
-		dev_err(card->dev, "Can't retrieve clk plla_out0\n");
-		return PTR_ERR(priv->clk_plla_out0);
-	}
+	if (IS_ERR(priv->clk_plla_out0))
+		return dev_err_probe(card->dev, PTR_ERR(priv->clk_plla_out0),
+				     "can't retrieve clk plla_out0\n");
+
+	ret = graph_util_card_probe(card);
+	if (ret < 0)
+		return dev_err_probe(card->dev, ret, "graph_util_card_probe failed\n");
 
-	return graph_util_card_probe(card);
+	return ret;
 }
 
 static int tegra_audio_graph_probe(struct platform_device *pdev)
-- 
2.17.1


  parent reply	other threads:[~2026-03-25 10:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 10:14 [PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures Sheetal
2026-03-25 10:14 ` [PATCH v3 01/14] ASoC: tegra: Use dev_err_probe() in tegra186_asrc probe Sheetal
2026-03-25 13:03   ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 02/14] ASoC: tegra: Use dev_err_probe() in tegra186_dspk probe Sheetal
2026-03-25 10:14 ` [PATCH v3 03/14] ASoC: tegra: Add error logging in tegra210_admaif driver Sheetal
2026-03-25 13:05   ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 04/14] ASoC: tegra: Add error logging in tegra210_adx driver Sheetal
2026-03-25 10:14 ` [PATCH v3 05/14] ASoC: tegra: Use dev_err_probe() in tegra210_ahub probe Sheetal
2026-03-25 13:07   ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 06/14] ASoC: tegra: Add error logging in tegra210_amx driver Sheetal
2026-03-25 10:14 ` [PATCH v3 07/14] ASoC: tegra: Use dev_err_probe() in tegra210_dmic probe Sheetal
2026-03-25 13:08   ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 08/14] ASoC: tegra: Add error logging in tegra210_i2s driver Sheetal
2026-03-25 10:14 ` [PATCH v3 09/14] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers Sheetal
2026-03-25 13:10   ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 10/14] ASoC: tegra: Use dev_err_probe() in tegra210_mixer probe Sheetal
2026-03-25 10:14 ` [PATCH v3 11/14] ASoC: tegra: Use dev_err_probe() in tegra210_mvc probe Sheetal
2026-03-25 10:14 ` [PATCH v3 12/14] ASoC: tegra: Use dev_err_probe() in tegra210_sfc probe Sheetal
2026-03-25 13:11   ` Mark Brown
2026-03-25 10:14 ` [PATCH v3 13/14] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe Sheetal
2026-03-25 10:14 ` Sheetal [this message]
2026-03-25 13:18 ` (subset) [PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325101437.3059693-15-sheetal@nvidia.com \
    --to=sheetal@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=perex@perex.cz \
    --cc=thierry.reding@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox