[PATCH] soc/tegra: fuse: Register nvmem lookups at probe

[PATCH] soc/tegra: fuse: Register nvmem lookups at probe

[Kartik Rajput]

Register nvmem lookups in tegra_fuse_probe(), after the nvmem device has
been registered, since they can only be used after the nvmem device is
registered.

Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
---
 drivers/soc/tegra/fuse/fuse-tegra.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
index 291484595dcf..d70ba4572c75 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra.c
@@ -182,10 +182,6 @@ static int tegra_fuse_probe(struct platform_device *pdev)
 		}
 
 		fuse->soc->init(fuse);
-
-		err = tegra_fuse_add_lookups(fuse);
-		if (err)
-			return dev_err_probe(&pdev->dev, err, "failed to add FUSE lookups\n");
 	}
 
 	fuse->clk = devm_clk_get_optional(&pdev->dev, "fuse");
@@ -231,6 +227,10 @@ static int tegra_fuse_probe(struct platform_device *pdev)
 		return err;
 	}
 
+	err = tegra_fuse_add_lookups(fuse);
+	if (err)
+		return dev_err_probe(&pdev->dev, err, "failed to add FUSE lookups\n");
+
 	fuse->rst = devm_reset_control_get_optional(&pdev->dev, "fuse");
 	if (IS_ERR(fuse->rst))
 		return dev_err_probe(&pdev->dev, PTR_ERR(fuse->rst), "failed to get FUSE reset\n");
@@ -566,10 +566,6 @@ static int __init tegra_init_fuse(void)
 
 	tegra_fuse_print_sku_info(&tegra_sku_info);
 
-	err = tegra_fuse_add_lookups(fuse);
-	if (err)
-		pr_err("failed to add FUSE lookups\n");
-
 	return err;
 }
 early_initcall(tegra_init_fuse);
-- 
2.43.0

Re: [PATCH] soc/tegra: fuse: Register nvmem lookups at probe

[kernel test robot]

Hi Kartik,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on linus/master v7.0-rc5 next-20260324]
[cannot apply to drm-tegra/drm/tegra/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kartik-Rajput/soc-tegra-fuse-Register-nvmem-lookups-at-probe/20260325-020016
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link:    https://lore.kernel.org/r/20260324114242.551939-1-kkartik%40nvidia.com
patch subject: [PATCH] soc/tegra: fuse: Register nvmem lookups at probe
config: arm-defconfig (https://download.01.org/0day-ci/archive/20260325/202603251045.wm2KjZbP-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 054e11d1a17e5ba88bb1a8ef32fad3346e80b186)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260325/202603251045.wm2KjZbP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603251045.wm2KjZbP-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/soc/tegra/fuse/fuse-tegra.c:569:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
     569 |         return err;
         |                ^~~
   drivers/soc/tegra/fuse/fuse-tegra.c:476:9: note: initialize the variable 'err' to silence this warning
     476 |         int err;
         |                ^
         |                 = 0
   1 warning generated.


vim +/err +569 drivers/soc/tegra/fuse/fuse-tegra.c

7e939de1b2bb26 Thierry Reding     2015-04-29  521  
7e939de1b2bb26 Thierry Reding     2015-04-29  522  			default:
7e939de1b2bb26 Thierry Reding     2015-04-29  523  				pr_warn("Unsupported SoC: %02x\n", chip);
7e939de1b2bb26 Thierry Reding     2015-04-29  524  				break;
7e939de1b2bb26 Thierry Reding     2015-04-29  525  			}
7e939de1b2bb26 Thierry Reding     2015-04-29  526  		} else {
7e939de1b2bb26 Thierry Reding     2015-04-29  527  			/*
7e939de1b2bb26 Thierry Reding     2015-04-29  528  			 * At this point we're not running on Tegra, so play
7e939de1b2bb26 Thierry Reding     2015-04-29  529  			 * nice with multi-platform kernels.
7e939de1b2bb26 Thierry Reding     2015-04-29  530  			 */
24fa5af81059af Thierry Reding     2014-07-11  531  			return 0;
7e939de1b2bb26 Thierry Reding     2015-04-29  532  		}
7e939de1b2bb26 Thierry Reding     2015-04-29  533  	} else {
7e939de1b2bb26 Thierry Reding     2015-04-29  534  		/*
7e939de1b2bb26 Thierry Reding     2015-04-29  535  		 * Extract information from the device tree if we've found a
7e939de1b2bb26 Thierry Reding     2015-04-29  536  		 * matching node.
7e939de1b2bb26 Thierry Reding     2015-04-29  537  		 */
7e939de1b2bb26 Thierry Reding     2015-04-29  538  		if (of_address_to_resource(np, 0, &regs) < 0) {
7e939de1b2bb26 Thierry Reding     2015-04-29  539  			pr_err("failed to get FUSE register\n");
7e939de1b2bb26 Thierry Reding     2015-04-29  540  			return -ENXIO;
7e939de1b2bb26 Thierry Reding     2015-04-29  541  		}
24fa5af81059af Thierry Reding     2014-07-11  542  
7e939de1b2bb26 Thierry Reding     2015-04-29  543  		fuse->soc = match->data;
7e939de1b2bb26 Thierry Reding     2015-04-29  544  	}
783c8f4c84451b Peter De Schrijver 2014-06-12  545  
783c8f4c84451b Peter De Schrijver 2014-06-12  546  	np = of_find_matching_node(NULL, car_match);
7e939de1b2bb26 Thierry Reding     2015-04-29  547  	if (np) {
7e939de1b2bb26 Thierry Reding     2015-04-29  548  		void __iomem *base = of_iomap(np, 0);
e941712cccab8a Liang He           2022-06-16  549  		of_node_put(np);
7e939de1b2bb26 Thierry Reding     2015-04-29  550  		if (base) {
7e939de1b2bb26 Thierry Reding     2015-04-29  551  			tegra_enable_fuse_clk(base);
7e939de1b2bb26 Thierry Reding     2015-04-29  552  			iounmap(base);
783c8f4c84451b Peter De Schrijver 2014-06-12  553  		} else {
7e939de1b2bb26 Thierry Reding     2015-04-29  554  			pr_err("failed to map clock registers\n");
7e939de1b2bb26 Thierry Reding     2015-04-29  555  			return -ENXIO;
7e939de1b2bb26 Thierry Reding     2015-04-29  556  		}
7e939de1b2bb26 Thierry Reding     2015-04-29  557  	}
7e939de1b2bb26 Thierry Reding     2015-04-29  558  
4bdc0d676a6431 Christoph Hellwig  2020-01-06  559  	fuse->base = ioremap(regs.start, resource_size(&regs));
7e939de1b2bb26 Thierry Reding     2015-04-29  560  	if (!fuse->base) {
7e939de1b2bb26 Thierry Reding     2015-04-29  561  		pr_err("failed to map FUSE registers\n");
24fa5af81059af Thierry Reding     2014-07-11  562  		return -ENXIO;
783c8f4c84451b Peter De Schrijver 2014-06-12  563  	}
783c8f4c84451b Peter De Schrijver 2014-06-12  564  
7e939de1b2bb26 Thierry Reding     2015-04-29  565  	fuse->soc->init(fuse);
783c8f4c84451b Peter De Schrijver 2014-06-12  566  
13a69354147e0a Kartik             2023-10-17  567  	tegra_fuse_print_sku_info(&tegra_sku_info);
24fa5af81059af Thierry Reding     2014-07-11  568  
71661c1c8c34d1 Kartik             2023-10-17 @569  	return err;
783c8f4c84451b Peter De Schrijver 2014-06-12  570  }
24fa5af81059af Thierry Reding     2014-07-11  571  early_initcall(tegra_init_fuse);
27a0342ac162bf Thierry Reding     2017-08-17  572  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki