* [PATCH v4 1/4] ASoC: tegra: Add error logging in tegra210_admaif driver
2026-04-01 11:24 [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Sheetal
@ 2026-04-01 11:24 ` Sheetal
2026-04-01 11:24 ` [PATCH v4 2/4] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers Sheetal
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sheetal @ 2026-04-01 11:24 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Thierry Reding, Jonathan Hunter
Cc: Jaroslav Kysela, Takashi Iwai, Mohan Kumar, Kuninori Morimoto,
linux-sound, linux-tegra, linux-kernel, Sheetal
Log errors in the Tegra210 ADMAIF probe and runtime callback paths.
Drop redundant dev_err() at tegra_isomgr_adma_register() call site
since it already logs errors internally.
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
sound/soc/tegra/tegra210_admaif.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/sound/soc/tegra/tegra210_admaif.c b/sound/soc/tegra/tegra210_admaif.c
index 0976779d29f2..a1b2c3d4e5f6 100644
--- a/sound/soc/tegra/tegra210_admaif.c
+++ b/sound/soc/tegra/tegra210_admaif.c
@@ -408,6 +408,7 @@ static int tegra_admaif_start(struct snd_soc_dai *dai, int direction)
reg = CH_RX_REG(TEGRA_ADMAIF_RX_ENABLE, dai->id);
break;
default:
+ dev_err(dai->dev, "invalid stream direction: %d\n", direction);
return -EINVAL;
}
@@ -441,6 +442,7 @@ static int tegra_admaif_stop(struct snd_soc_dai *dai, int direction)
reset_reg = CH_RX_REG(TEGRA_ADMAIF_RX_SOFT_RESET, dai->id);
break;
default:
+ dev_err(dai->dev, "invalid stream direction: %d\n", direction);
return -EINVAL;
}
@@ -489,6 +491,7 @@ static int tegra_admaif_trigger(struct snd_pcm_substream *substream, int cmd,
case SNDRV_PCM_TRIGGER_SUSPEND:
return tegra_admaif_stop(dai, substream->stream);
default:
+ dev_err(dai->dev, "invalid trigger command: %d\n", cmd);
return -EINVAL;
}
}
@@ -958,10 +961,9 @@ static int tegra_admaif_probe(struct platform_device *pdev)
admaif->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
admaif->soc_data->regmap_conf);
- if (IS_ERR(admaif->regmap)) {
- dev_err(&pdev->dev, "regmap init failed\n");
- return PTR_ERR(admaif->regmap);
- }
+ if (IS_ERR(admaif->regmap))
+ return dev_err_probe(&pdev->dev, PTR_ERR(admaif->regmap),
+ "regmap init failed\n");
regcache_cache_only(admaif->regmap, true);
@@ -968,7 +970,5 @@ static int tegra_admaif_probe(struct platform_device *pdev)
err = tegra_isomgr_adma_register(&pdev->dev);
- if (err) {
- dev_err(&pdev->dev, "Failed to add interconnect path\n");
- return err;
- }
+ if (err)
+ return err;
regmap_update_bits(admaif->regmap, admaif->soc_data->global_base +
@@ -1009,11 +1009,9 @@ static int tegra_admaif_probe(struct platform_device *pdev)
admaif->soc_data->cmpnt,
admaif->soc_data->dais,
admaif->soc_data->num_ch);
- if (err) {
- dev_err(&pdev->dev,
- "can't register ADMAIF component, err: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(&pdev->dev, err,
+ "can't register ADMAIF component\n");
pm_runtime_enable(&pdev->dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v4 2/4] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers
2026-04-01 11:24 [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Sheetal
2026-04-01 11:24 ` [PATCH v4 1/4] ASoC: tegra: Add error logging in tegra210_admaif driver Sheetal
@ 2026-04-01 11:24 ` Sheetal
2026-04-01 11:24 ` [PATCH v4 3/4] ASoC: tegra: Use dev_err_probe() for regmap init failures Sheetal
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sheetal @ 2026-04-01 11:24 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Thierry Reding, Jonathan Hunter
Cc: Jaroslav Kysela, Takashi Iwai, Mohan Kumar, Kuninori Morimoto,
linux-sound, linux-tegra, linux-kernel, Sheetal
Log errors in the Tegra210 OPE, PEQ and MBDRC probe paths using
dev_err_probe(). Drop redundant dev_err() at tegra210_peq_regmap_init()
and tegra210_mbdrc_regmap_init() call sites in ope_probe() since
these functions already log errors internally.
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
sound/soc/tegra/tegra210_mbdrc.c | 19 ++++++++++---------
sound/soc/tegra/tegra210_ope.c | 26 ++++++++++----------------
sound/soc/tegra/tegra210_peq.c | 19 ++++++++++---------
3 files changed, 30 insertions(+), 34 deletions(-)
diff --git a/sound/soc/tegra/tegra210_mbdrc.c b/sound/soc/tegra/tegra210_mbdrc.c
index 6a268dbb7197..b1c2d3e4f5a6 100644
--- a/sound/soc/tegra/tegra210_mbdrc.c
+++ b/sound/soc/tegra/tegra210_mbdrc.c
@@ -988,14 +988,14 @@ int tegra210_mbdrc_regmap_init(struct platform_device *pdev)
child = of_get_child_by_name(dev->of_node, "dynamic-range-compressor");
if (!child)
- return -ENODEV;
+ return dev_err_probe(dev, -ENODEV,
+ "missing 'dynamic-range-compressor' DT child node\n");
err = of_address_to_resource(child, 0, &mem);
of_node_put(child);
- if (err < 0) {
- dev_err(dev, "fail to get MBDRC resource\n");
- return err;
- }
+ if (err < 0)
+ return dev_err_probe(dev, err,
+ "failed to get MBDRC resource\n");
mem.flags = IORESOURCE_MEM;
regs = devm_ioremap_resource(dev, &mem);
@@ -1004,10 +1004,9 @@ int tegra210_mbdrc_regmap_init(struct platform_device *pdev)
ope->mbdrc_regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_mbdrc_regmap_cfg);
- if (IS_ERR(ope->mbdrc_regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(ope->mbdrc_regmap);
- }
+ if (IS_ERR(ope->mbdrc_regmap))
+ return dev_err_probe(dev, PTR_ERR(ope->mbdrc_regmap),
+ "MBDRC regmap init failed\n");
regcache_cache_only(ope->mbdrc_regmap, true);
diff --git a/sound/soc/tegra/tegra210_ope.c b/sound/soc/tegra/tegra210_ope.c
index a440888dcdbd..c1d2e3f4a5b6 100644
--- a/sound/soc/tegra/tegra210_ope.c
+++ b/sound/soc/tegra/tegra210_ope.c
@@ -318,10 +318,9 @@ static int tegra210_ope_probe(struct platform_device *pdev)
ope->regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_ope_regmap_config);
- if (IS_ERR(ope->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(ope->regmap);
- }
+ if (IS_ERR(ope->regmap))
+ return dev_err_probe(dev, PTR_ERR(ope->regmap),
+ "regmap init failed\n");
regcache_cache_only(ope->regmap, true);
@@ -328,14 +327,10 @@ static int tegra210_ope_probe(struct platform_device *pdev)
dev_set_drvdata(dev, ope);
err = tegra210_peq_regmap_init(pdev);
- if (err < 0) {
- dev_err(dev, "PEQ init failed\n");
- return err;
- }
+ if (err < 0)
+ return err;
err = tegra210_mbdrc_regmap_init(pdev);
- if (err < 0) {
- dev_err(dev, "MBDRC init failed\n");
- return err;
- }
+ if (err < 0)
+ return err;
@@ -342,10 +337,9 @@ static int tegra210_ope_probe(struct platform_device *pdev)
err = devm_snd_soc_register_component(dev, &tegra210_ope_cmpnt,
tegra210_ope_dais,
ARRAY_SIZE(tegra210_ope_dais));
- if (err) {
- dev_err(dev, "can't register OPE component, err: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err,
+ "can't register OPE component\n");
pm_runtime_enable(dev);
diff --git a/sound/soc/tegra/tegra210_peq.c b/sound/soc/tegra/tegra210_peq.c
index 2f72e9d541dc..d1e2f3a4b5c6 100644
--- a/sound/soc/tegra/tegra210_peq.c
+++ b/sound/soc/tegra/tegra210_peq.c
@@ -408,14 +408,14 @@ int tegra210_peq_regmap_init(struct platform_device *pdev)
child = of_get_child_by_name(dev->of_node, "equalizer");
if (!child)
- return -ENODEV;
+ return dev_err_probe(dev, -ENODEV,
+ "missing 'equalizer' DT child node\n");
err = of_address_to_resource(child, 0, &mem);
of_node_put(child);
- if (err < 0) {
- dev_err(dev, "fail to get PEQ resource\n");
- return err;
- }
+ if (err < 0)
+ return dev_err_probe(dev, err,
+ "failed to get PEQ resource\n");
mem.flags = IORESOURCE_MEM;
regs = devm_ioremap_resource(dev, &mem);
@@ -423,10 +423,9 @@ int tegra210_peq_regmap_init(struct platform_device *pdev)
return PTR_ERR(regs);
ope->peq_regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_peq_regmap_config);
- if (IS_ERR(ope->peq_regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(ope->peq_regmap);
- }
+ if (IS_ERR(ope->peq_regmap))
+ return dev_err_probe(dev, PTR_ERR(ope->peq_regmap),
+ "PEQ regmap init failed\n");
regcache_cache_only(ope->peq_regmap, true);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v4 3/4] ASoC: tegra: Use dev_err_probe() for regmap init failures
2026-04-01 11:24 [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Sheetal
2026-04-01 11:24 ` [PATCH v4 1/4] ASoC: tegra: Add error logging in tegra210_admaif driver Sheetal
2026-04-01 11:24 ` [PATCH v4 2/4] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers Sheetal
@ 2026-04-01 11:24 ` Sheetal
2026-04-01 11:25 ` [PATCH v4 4/4] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe Sheetal
2026-04-01 13:53 ` [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Mark Brown
4 siblings, 0 replies; 6+ messages in thread
From: Sheetal @ 2026-04-01 11:24 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Thierry Reding, Jonathan Hunter
Cc: Jaroslav Kysela, Takashi Iwai, Mohan Kumar, Kuninori Morimoto,
linux-sound, linux-tegra, linux-kernel, Sheetal
Use dev_err_probe() for regmap init failures in Tegra audio driver
probe paths.
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
sound/soc/tegra/tegra186_asrc.c | 7 +++----
sound/soc/tegra/tegra186_dspk.c | 7 +++----
sound/soc/tegra/tegra210_adx.c | 7 +++----
sound/soc/tegra/tegra210_ahub.c | 7 +++----
sound/soc/tegra/tegra210_amx.c | 7 +++----
sound/soc/tegra/tegra210_dmic.c | 7 +++----
sound/soc/tegra/tegra210_i2s.c | 7 +++----
sound/soc/tegra/tegra210_mixer.c | 7 +++----
sound/soc/tegra/tegra210_mvc.c | 7 +++----
sound/soc/tegra/tegra210_sfc.c | 7 +++----
10 files changed, 30 insertions(+), 40 deletions(-)
diff --git a/sound/soc/tegra/tegra186_asrc.c b/sound/soc/tegra/tegra186_asrc.c
index 98e911e2ed74..a2b3c4d5e6f7 100644
--- a/sound/soc/tegra/tegra186_asrc.c
+++ b/sound/soc/tegra/tegra186_asrc.c
@@ -989,10 +989,9 @@ static int tegra186_asrc_platform_probe(struct platform_device *pdev)
asrc->regmap = devm_regmap_init_mmio(dev, regs,
&tegra186_asrc_regmap_config);
- if (IS_ERR(asrc->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(asrc->regmap);
- }
+ if (IS_ERR(asrc->regmap))
+ return dev_err_probe(dev, PTR_ERR(asrc->regmap),
+ "regmap init failed\n");
asrc->soc_data = of_device_get_match_data(&pdev->dev);
diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dspk.c
index 1aa94c98294a..b3c4d5e6f7a8 100644
--- a/sound/soc/tegra/tegra186_dspk.c
+++ b/sound/soc/tegra/tegra186_dspk.c
@@ -505,10 +505,9 @@ static int tegra186_dspk_platform_probe(struct platform_device *pdev)
return PTR_ERR(regs);
dspk->regmap = devm_regmap_init_mmio(dev, regs, &tegra186_dspk_regmap);
- if (IS_ERR(dspk->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(dspk->regmap);
- }
+ if (IS_ERR(dspk->regmap))
+ return dev_err_probe(dev, PTR_ERR(dspk->regmap),
+ "regmap init failed\n");
regcache_cache_only(dspk->regmap, true);
diff --git a/sound/soc/tegra/tegra210_adx.c b/sound/soc/tegra/tegra210_adx.c
index d7d075fd54b2..c4d5e6f7a8b9 100644
--- a/sound/soc/tegra/tegra210_adx.c
+++ b/sound/soc/tegra/tegra210_adx.c
@@ -697,10 +697,9 @@ static int tegra210_adx_platform_probe(struct platform_device *pdev)
adx->regmap = devm_regmap_init_mmio(dev, regs,
soc_data->regmap_conf);
- if (IS_ERR(adx->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(adx->regmap);
- }
+ if (IS_ERR(adx->regmap))
+ return dev_err_probe(dev, PTR_ERR(adx->regmap),
+ "regmap init failed\n");
regcache_cache_only(adx->regmap, true);
diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c
index 4626dd0a4d55..d5e6f7a8b9c0 100644
--- a/sound/soc/tegra/tegra210_ahub.c
+++ b/sound/soc/tegra/tegra210_ahub.c
@@ -2275,10 +2275,9 @@ static int tegra_ahub_probe(struct platform_device *pdev)
ahub->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
ahub->soc_data->regmap_config);
- if (IS_ERR(ahub->regmap)) {
- dev_err(&pdev->dev, "regmap init failed\n");
- return PTR_ERR(ahub->regmap);
- }
+ if (IS_ERR(ahub->regmap))
+ return dev_err_probe(&pdev->dev, PTR_ERR(ahub->regmap),
+ "regmap init failed\n");
regcache_cache_only(ahub->regmap, true);
diff --git a/sound/soc/tegra/tegra210_amx.c b/sound/soc/tegra/tegra210_amx.c
index 1b7fb84a0f34..e6f7a8b9c0d1 100644
--- a/sound/soc/tegra/tegra210_amx.c
+++ b/sound/soc/tegra/tegra210_amx.c
@@ -745,10 +745,9 @@ static int tegra210_amx_platform_probe(struct platform_device *pdev)
amx->regmap = devm_regmap_init_mmio(dev, regs,
amx->soc_data->regmap_conf);
- if (IS_ERR(amx->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(amx->regmap);
- }
+ if (IS_ERR(amx->regmap))
+ return dev_err_probe(dev, PTR_ERR(amx->regmap),
+ "regmap init failed\n");
regcache_cache_only(amx->regmap, true);
diff --git a/sound/soc/tegra/tegra210_dmic.c b/sound/soc/tegra/tegra210_dmic.c
index 5a4bd5cef30a..f7a8b9c0d1e2 100644
--- a/sound/soc/tegra/tegra210_dmic.c
+++ b/sound/soc/tegra/tegra210_dmic.c
@@ -517,10 +517,9 @@ static int tegra210_dmic_probe(struct platform_device *pdev)
dmic->regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_dmic_regmap_config);
- if (IS_ERR(dmic->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(dmic->regmap);
- }
+ if (IS_ERR(dmic->regmap))
+ return dev_err_probe(dev, PTR_ERR(dmic->regmap),
+ "regmap init failed\n");
regcache_cache_only(dmic->regmap, true);
diff --git a/sound/soc/tegra/tegra210_i2s.c b/sound/soc/tegra/tegra210_i2s.c
index 7bf76c9b640f..a8b9c0d1e2f3 100644
--- a/sound/soc/tegra/tegra210_i2s.c
+++ b/sound/soc/tegra/tegra210_i2s.c
@@ -1093,10 +1093,9 @@ static int tegra210_i2s_probe(struct platform_device *pdev)
i2s->regmap = devm_regmap_init_mmio(dev, regs,
i2s->soc_data->regmap_conf);
- if (IS_ERR(i2s->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(i2s->regmap);
- }
+ if (IS_ERR(i2s->regmap))
+ return dev_err_probe(dev, PTR_ERR(i2s->regmap),
+ "regmap init failed\n");
tegra210_parse_client_convert(dev);
diff --git a/sound/soc/tegra/tegra210_mixer.c b/sound/soc/tegra/tegra210_mixer.c
index d9318aaaf32e..b9c0d1e2f3a4 100644
--- a/sound/soc/tegra/tegra210_mixer.c
+++ b/sound/soc/tegra/tegra210_mixer.c
@@ -814,10 +814,9 @@ static int tegra210_mixer_platform_probe(struct platform_device *pdev)
mixer->regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_mixer_regmap_config);
- if (IS_ERR(mixer->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(mixer->regmap);
- }
+ if (IS_ERR(mixer->regmap))
+ return dev_err_probe(dev, PTR_ERR(mixer->regmap),
+ "regmap init failed\n");
regcache_cache_only(mixer->regmap, true);
diff --git a/sound/soc/tegra/tegra210_mvc.c b/sound/soc/tegra/tegra210_mvc.c
index 11bd0ea22797..c0d1e2f3a4b5 100644
--- a/sound/soc/tegra/tegra210_mvc.c
+++ b/sound/soc/tegra/tegra210_mvc.c
@@ -731,10 +731,9 @@ static int tegra210_mvc_platform_probe(struct platform_device *pdev)
mvc->regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_mvc_regmap_config);
- if (IS_ERR(mvc->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(mvc->regmap);
- }
+ if (IS_ERR(mvc->regmap))
+ return dev_err_probe(dev, PTR_ERR(mvc->regmap),
+ "regmap init failed\n");
regcache_cache_only(mvc->regmap, true);
diff --git a/sound/soc/tegra/tegra210_sfc.c b/sound/soc/tegra/tegra210_sfc.c
index 0f342fae058f..d1e2f3a4b5c6 100644
--- a/sound/soc/tegra/tegra210_sfc.c
+++ b/sound/soc/tegra/tegra210_sfc.c
@@ -3598,10 +3598,9 @@ static int tegra210_sfc_platform_probe(struct platform_device *pdev)
sfc->regmap = devm_regmap_init_mmio(dev, regs,
&tegra210_sfc_regmap_config);
- if (IS_ERR(sfc->regmap)) {
- dev_err(dev, "regmap init failed\n");
- return PTR_ERR(sfc->regmap);
- }
+ if (IS_ERR(sfc->regmap))
+ return dev_err_probe(dev, PTR_ERR(sfc->regmap),
+ "regmap init failed\n");
regcache_cache_only(sfc->regmap, true);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v4 4/4] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe
2026-04-01 11:24 [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Sheetal
` (2 preceding siblings ...)
2026-04-01 11:24 ` [PATCH v4 3/4] ASoC: tegra: Use dev_err_probe() for regmap init failures Sheetal
@ 2026-04-01 11:25 ` Sheetal
2026-04-01 13:53 ` [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Mark Brown
4 siblings, 0 replies; 6+ messages in thread
From: Sheetal @ 2026-04-01 11:25 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Thierry Reding, Jonathan Hunter
Cc: Jaroslav Kysela, Takashi Iwai, Mohan Kumar, Kuninori Morimoto,
linux-sound, linux-tegra, linux-kernel, Sheetal
Use dev_err_probe() for clock errors in the tegra_asoc_machine
probe path.
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
sound/soc/tegra/tegra_asoc_machine.c | 21 ++++++++++-----------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/sound/soc/tegra/tegra_asoc_machine.c b/sound/soc/tegra/tegra_asoc_machine.c
index d7245a10bba1..e1f2a3b4c5d6 100644
--- a/sound/soc/tegra/tegra_asoc_machine.c
+++ b/sound/soc/tegra/tegra_asoc_machine.c
@@ -591,16 +591,14 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)
* host controller and the external codec
*/
err = clk_set_rate(machine->clk_pll_a, 73728000);
- if (err) {
- dev_err(dev, "Can't set pll_a rate: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err,
+ "can't set pll_a rate\n");
err = clk_set_rate(machine->clk_pll_a_out0, 24576000);
- if (err) {
- dev_err(dev, "Can't set pll_a_out0 rate: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err,
+ "can't set pll_a_out0 rate\n");
machine->set_baseclock = 73728000;
machine->set_mclk = 24576000;
@@ -612,10 +610,9 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)
* only needed for audio.
*/
err = clk_prepare_enable(machine->clk_cdev1);
- if (err) {
- dev_err(dev, "Can't enable cdev1: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err,
+ "can't enable cdev1\n");
err = devm_snd_soc_register_card(dev, card);
if (err)
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures
2026-04-01 11:24 [PATCH v4 0/4] ASoC: tegra: Add error logging for probe and callback failures Sheetal
` (3 preceding siblings ...)
2026-04-01 11:25 ` [PATCH v4 4/4] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe Sheetal
@ 2026-04-01 13:53 ` Mark Brown
4 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2026-04-01 13:53 UTC (permalink / raw)
To: Liam Girdwood, Thierry Reding, Jonathan Hunter, Sheetal
Cc: Jaroslav Kysela, Takashi Iwai, Mohan Kumar, Kuninori Morimoto,
linux-sound, linux-tegra, linux-kernel
On Wed, 01 Apr 2026 11:24:56 +0000, Sheetal wrote:
> ASoC: tegra: Add error logging for probe and callback failures
>
> Resend pending v3 patches with fixes and add remaining
> dev_err_probe() conversions.
>
> Patch 1 replaces v3 patch 03/14 (ADMAIF).
> Patch 2 replaces v3 patch 09/14 (OPE/PEQ/MBDRC).
> Patch 3 is new - adds regmap init conversions across 10 drivers.
> Patch 4 is new - adds clock error conversions in tegra_asoc_machine.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
Thanks!
[1/4] ASoC: tegra: Add error logging in tegra210_admaif driver
https://git.kernel.org/broonie/sound/c/00d6070ec02c
[2/4] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers
https://git.kernel.org/broonie/sound/c/2333abb25c7e
[3/4] ASoC: tegra: Use dev_err_probe() for regmap init failures
https://git.kernel.org/broonie/sound/c/4a8fe27e122e
[4/4] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe
https://git.kernel.org/broonie/sound/c/b015ef4eaeff
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread