public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Ashish Mhetre <amhetre@nvidia.com>
To: <krzk@kernel.org>, <thierry.reding@kernel.org>, <jonathanh@nvidia.com>
Cc: <ketanp@nvidia.com>, <linux-kernel@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, Ashish Mhetre <amhetre@nvidia.com>
Subject: [PATCH V3 0/3] memory: tegra: Restore MC state on system resume
Date: Thu, 30 Apr 2026 09:51:59 +0000	[thread overview]
Message-ID: <20260430095202.1167651-1-amhetre@nvidia.com> (raw)

The tegra-mc platform driver does not register any dev_pm_ops, so the
SoC-specific ->resume() is never invoked (e.g. tegra186_mc_resume) on
system wake. On Tegra186 and later this means MC client Stream-ID
override registers are not reprogrammed, and clients behind the ARM
SMMU fault on the first DMA after resume.

Patch 1 makes the SoC-level ->resume() callback return void, since the
sole implementation never fails. This simplifies the wrapper added in
the next patch.

Patch 2 registers a dev_pm_ops on the tegra-mc driver and routes the
system resume callback into mc->soc->ops->resume() so the existing SID
restore path runs again on wake.

Patch 3 factors the existing intmask programming out of
tegra_mc_probe() into a helper and reuses it from the resume path so
the MC interrupt mask state, which is also lost across SC7, is
restored on wake too.

Changes in V3:
- New patch 1 to change the SoC ->resume() callback return type from
  int to void, so the wrapper in patch 2 does not need to deal with
  an err value that is always 0. (Jon Hunter)
- Patches 2 and 3 simplified accordingly, no other functional change.

Changes in V2:
- Split the original single patch into two - register the PM ops and
  reprogram the MC interrupt masks on resume.

Ashish Mhetre (3):
  memory: tegra: Make ->resume() callback return void
  memory: tegra: Wire up system sleep PM ops
  memory: tegra: Restore MC interrupt masks on resume

 drivers/memory/tegra/mc.c       | 37 ++++++++++++++++++++++++++-------
 drivers/memory/tegra/tegra186.c |  4 +---
 include/soc/tegra/mc.h          |  2 +-
 3 files changed, 32 insertions(+), 11 deletions(-)

-- 
2.50.1


             reply	other threads:[~2026-04-30  9:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30  9:51 Ashish Mhetre [this message]
2026-04-30  9:52 ` [PATCH V3 1/3] memory: tegra: Make ->resume() callback return void Ashish Mhetre
2026-04-30  9:52 ` [PATCH V3 2/3] memory: tegra: Wire up system sleep PM ops Ashish Mhetre
2026-04-30  9:52 ` [PATCH V3 3/3] memory: tegra: Restore MC interrupt masks on resume Ashish Mhetre
2026-04-30 11:42   ` Jon Hunter
2026-05-01  9:26     ` Krzysztof Kozlowski
2026-05-01 10:29 ` [PATCH V3 0/3] memory: tegra: Restore MC state on system resume Jon Hunter
2026-05-04 17:48 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430095202.1167651-1-amhetre@nvidia.com \
    --to=amhetre@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=ketanp@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox