From: Ethan Tidmore <ethantidmore06@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
Kees Cook <kees@kernel.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Ethan Tidmore <ethantidmore06@gmail.com>
Subject: [PATCH] memory: tegra: Fix possible null pointer dereference
Date: Thu, 7 May 2026 20:57:16 -0500 [thread overview]
Message-ID: <20260508015716.652347-1-ethantidmore06@gmail.com> (raw)
The function tegra114_emc_find_timing() has the possibility of returning
null and it's return value 'timing' is dereferenced before it is
checked for null.
Place dereference after null pointer check.
Detected by Smatch:
drivers/memory/tegra/tegra114-emc.c:520 tegra114_emc_prepare_timing_change()
warn: variable dereferenced before check 'timing' (see line 515)
Fixes: dce208b5405f4 ("memory: tegra: Add Tegra114 EMC driver")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/memory/tegra/tegra114-emc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/tegra/tegra114-emc.c b/drivers/memory/tegra/tegra114-emc.c
index be6c699cb656..fc3bf1a28630 100644
--- a/drivers/memory/tegra/tegra114-emc.c
+++ b/drivers/memory/tegra/tegra114-emc.c
@@ -512,14 +512,16 @@ static int tegra114_emc_prepare_timing_change(struct tegra_emc *emc,
enum emc_dll_change dll_change;
unsigned int pre_wait = 0;
u32 val, mask;
- bool next_dll_enabled = !(timing->emc_mode_1 & 0x1);
bool last_dll_enabled = !(last->emc_mode_1 & 0x1);
bool update = false;
+ bool next_dll_enabled;
unsigned int i;
if (!timing)
return -ENOENT;
+ next_dll_enabled = !(timing->emc_mode_1 & 0x1);
+
if (next_dll_enabled == last_dll_enabled)
dll_change = DLL_CHANGE_NONE;
else if (next_dll_enabled)
--
2.54.0
next reply other threads:[~2026-05-08 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 1:57 Ethan Tidmore [this message]
2026-05-08 10:13 ` [PATCH] memory: tegra: Fix possible null pointer dereference Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508015716.652347-1-ethantidmore06@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=clamor95@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kees@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox