From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3903F6C2C; Fri, 26 Jun 2026 14:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782484396; cv=none; b=ctCZYxlZ9/T0vse5fY0V6v0E6nB1BSOMaXDx2HPm4axWmeQznNXiOMpnO1yMnt5SMx2EJ+k4tXi2M9Lue1JozrmrL+aXyTri3UGzN5wSv8/RLeITvXV2jKcT7z1jdackX+hy/TsSvlhLgB474T4oxWPsSXYoM1ESrLXWVyz3urw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782484396; c=relaxed/simple; bh=CZ0z/+7L9rBI6NAopwzlR5/H/pl2Sg7uOENYiAE89Ak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rHuySFXAb35QDQN0jMy/0BHkHd1VAh1inEzfVTI/+hRA3CFvNZORbTnABtcgU84homo5QXV0uvVzZKDfm0M4cBQAvJw4LZQ0GnKI0qPu4v6T/etBgdiz16K2A8adYsPkOdK04ZCVXQ+BdyijadoLxyrpxMRlU46EU10h9aTpiVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=OaYJp02L; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OaYJp02L" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EA78C174; Fri, 26 Jun 2026 16:32:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782484351; bh=CZ0z/+7L9rBI6NAopwzlR5/H/pl2Sg7uOENYiAE89Ak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OaYJp02L6ggXbNKJ/p2G+39jSfZv0m5HXuoGPk5gwlYg45jbwCXrNgBQABA/rtwSX xHDRhxB62BtiG8pCegOGjkel7zkI0idDXw2VeWyHUqi/4jZXyDdxPGMcHS1nW7M8v5 aB8LSibRy+/Jc2bFx4uj682WX9fxn98nDwtTMMKI= Date: Fri, 26 Jun 2026 17:33:10 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacopo Mondi , Sakari Ailus , Jimmy Su , Matthias Fend , Mikhail Rudenko , Daniel Scally , Jacopo Mondi , Michael Riesch , Benjamin Mugnier , Sylvain Petinot , Paul Elder , Martin Kepplinger , Quentin Schulz , Tommaso Merciai , Svyatoslav Ryhel , Richard Acayan , Thierry Reding , Jonathan Hunter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux@ew.tq-group.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 4/8] ARM: tegra: Convert to new media orientation definitions Message-ID: <20260626143310.GF2363897@killaraus.ideasonboard.com> References: <20260626-kbingham-orientation-v2-0-47178be927b4@ideasonboard.com> <20260626-kbingham-orientation-v2-4-47178be927b4@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260626-kbingham-orientation-v2-4-47178be927b4@ideasonboard.com> On Fri, Jun 26, 2026 at 01:07:56PM +0100, Kieran Bingham wrote: > The orientation property for video interface devices now has definitions > to prevent hardcoded integer values for the enum options. > > Update the users throughout the nvidia device trees to use the new > definitions. > > Signed-off-by: Kieran Bingham > --- > arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi | 3 ++- > arch/arm/boot/dts/nvidia/tegra30-asus-transformer-common.dtsi | 3 ++- > arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts | 4 +++- > arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi | 3 ++- > 4 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi > index 892d718294dd..a7fdd194300c 100644 > --- a/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi > +++ b/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -991,7 +992,7 @@ front-camera@48 { > vdd-supply = <&vddio_cam>; > vaa-supply = <&avdd_cam1>; > > - orientation = <0>; /* Front camera */ > + orientation = ; > > assigned-clocks = <&tegra_car TEGRA30_CLK_VI_SENSOR>, > <&tegra_car TEGRA30_CLK_CSUS>; > diff --git a/arch/arm/boot/dts/nvidia/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/nvidia/tegra30-asus-transformer-common.dtsi > index bf1c3a31d406..76286e15684c 100644 > --- a/arch/arm/boot/dts/nvidia/tegra30-asus-transformer-common.dtsi > +++ b/arch/arm/boot/dts/nvidia/tegra30-asus-transformer-common.dtsi > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > #include > > #include "tegra30.dtsi" > @@ -1262,7 +1263,7 @@ front-camera@48 { > vdd-supply = <&vdd_1v8_cam>; > vaa-supply = <&avdd_2v85_fcam>; > > - orientation = <0>; /* Front camera */ > + orientation = ; > > assigned-clocks = <&tegra_car TEGRA30_CLK_VI_SENSOR>, > <&tegra_car TEGRA30_CLK_CSUS>; > diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts b/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts > index 896639599c12..28680063bcc0 100644 > --- a/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts > +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts > @@ -1,6 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > /dts-v1/; > > +#include > + > #include "tegra30-lg-x3.dtsi" > > / { > @@ -132,7 +134,7 @@ front-camera@48 { > vdd-supply = <&vt_1v8_front>; > vaa-supply = <&vt_2v8_front>; > > - orientation = <0>; /* Front camera */ > + orientation = ; > > assigned-clocks = <&tegra_car TEGRA30_CLK_VI_SENSOR>, > <&tegra_car TEGRA30_CLK_CSUS>; > diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi > index 60e8a19aa70e..c58e3026a115 100644 > --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi > +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1216,7 +1217,7 @@ rear-camera@10 { > dvdd-supply = <&vdd_1v2_rear>; > avdd-supply = <&vdd_2v7_rear>; > > - orientation = <1>; /* Rear camera */ > + orientation = ; This should be MEDIA_ORIENTATION_BACK. And you should compile all the device trees the series touch. Reviewed-by: Laurent Pinchart > rotation = <90>; > > nvmem = <&m24c08>; -- Regards, Laurent Pinchart