From: Greg KH <gregkh@linuxfoundation.org>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: thierry.reding@kernel.org, airlied@gmail.com, simona@ffwll.ch,
jonathanh@nvidia.com, WenTao Liang <vulab@iscas.ac.cn>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/tegra: fix host1x_bo_pin leak in tegra_dc_pin error path
Date: Tue, 30 Jun 2026 11:19:56 +0200 [thread overview]
Message-ID: <2026063044-multiple-lion-95fe@gregkh> (raw)
In-Reply-To: <6iIwnfniQ6-oslWmeLae0A@nvidia.com>
On Mon, Jun 29, 2026 at 02:59:05PM +0900, Mikko Perttunen wrote:
> On Monday, June 29, 2026 12:02 AM WenTao Liang wrote:
> > When map->chunks > 1 triggers an error, the function jumps to unpin
> > before storing the current map in state->map[i]. The unpin loop only
> > cleans up previously pinned planes (indices 0 through i-1), so the
> > current mapping returned by host1x_bo_pin is never released via
> > host1x_bo_unpin.
> >
> > Suggested-by: Greg KH <gregkh@linuxfoundation.org>
> > Fixes: c6aeaf56f468 ("drm/tegra: Implement correct DMA-BUF semantics")
>
> This patch changes the code around the line, but doesn't look like it's
> the origin of the bug. Rather, I think commit
>
> 49f821919bb9d45de7f1cde6072de01d36235b5d
>
> is the origin.
>
> Aside from that,
>
> Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
I did not suggest this, so please do not accept this patch.
prev parent reply other threads:[~2026-06-30 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 15:02 [PATCH v2] drm/tegra: fix host1x_bo_pin leak in tegra_dc_pin error path WenTao Liang
2026-06-29 5:59 ` Mikko Perttunen
2026-06-30 9:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026063044-multiple-lion-95fe@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox