From: Pan Chuang <panchuang@vivo.com>
To: "Thierry Reding" <thierry.reding@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Sumit Gupta" <sumitg@nvidia.com>,
"Bruno Sobreira França" <brunofrancadevsec@gmail.com>,
"Shashank Balaji" <shashank.mahadasyam@sony.com>,
"Pan Chuang" <panchuang@vivo.com>,
linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE
SUPPORT), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 5/7] soc/tegra: cbb: Remove redundant dev_err()
Date: Mon, 20 Jul 2026 17:59:11 +0800 [thread overview]
Message-ID: <20260720095920.542801-6-panchuang@vivo.com> (raw)
In-Reply-To: <20260720095920.542801-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/tegra/cbb/tegra194-cbb.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
index 2f69e104c838..69ef929e04f8 100644
--- a/drivers/soc/tegra/cbb/tegra194-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
@@ -2072,20 +2072,15 @@ static int tegra194_cbb_interrupt_enable(struct tegra_cbb *cbb)
if (priv->sec_irq) {
err = devm_request_irq(dev, priv->sec_irq, tegra194_cbb_err_isr, 0, dev_name(dev),
priv);
- if (err) {
- dev_err(dev, "failed to register interrupt %u: %d\n", priv->sec_irq, err);
+ if (err)
return err;
- }
}
if (priv->nonsec_irq) {
err = devm_request_irq(dev, priv->nonsec_irq, tegra194_cbb_err_isr, 0,
dev_name(dev), priv);
- if (err) {
- dev_err(dev, "failed to register interrupt %u: %d\n", priv->nonsec_irq,
- err);
+ if (err)
return err;
- }
}
return 0;
--
2.34.1
prev parent reply other threads:[~2026-07-20 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:59 [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 9:59 ` Pan Chuang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720095920.542801-6-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=brunofrancadevsec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=shashank.mahadasyam@sony.com \
--cc=sumitg@nvidia.com \
--cc=thierry.reding@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox