From: Jakub Kicinski <kuba@kernel.org>
To: vadik likholetov <vadikas@gmail.com>
Cc: netdev@vger.kernel.org, maxime.chevallier@bootlin.com,
andrew@lunn.ch, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
thierry.reding@kernel.org, jonathanh@nvidia.com,
vbhadram@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: stmmac: enable the MAC on link up for all supported speeds
Date: Tue, 21 Jul 2026 15:42:33 -0700 [thread overview]
Message-ID: <20260721154233.77e5b97f@kernel.org> (raw)
In-Reply-To: <20260713074911.30090-1-vadikas@gmail.com>
On Mon, 13 Jul 2026 10:49:11 +0300 vadik likholetov wrote:
> stmmac_mac_link_down() clears the MAC's transmit and receive enable bits.
> stmmac_mac_link_up() is expected to set them again through
> stmmac_mac_set(..., true), but it first switches on the negotiated speed
> and returns early for a speed the switch does not list. The MAC is then
> left gated off.
FWIW Sashiko has some complaints:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260713074911.30090-1-vadikas@gmail.com
but that reads as a separate issue?
prev parent reply other threads:[~2026-07-21 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 7:49 [PATCH net v3] net: stmmac: enable the MAC on link up for all supported speeds vadik likholetov
2026-07-15 19:46 ` Jacob Keller
2026-07-15 20:15 ` Maxime Chevallier
2026-07-21 22:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721154233.77e5b97f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thierry.reding@kernel.org \
--cc=vadikas@gmail.com \
--cc=vbhadram@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox