From: Abraham Zukor <abe@maticrobots.com>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Abraham Zukor <abe@maticrobots.com>,
Mark Brown <broonie@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: tegra114: initialize native chip selects inactive
Date: Tue, 11 Aug 2026 22:38:59 -0700 [thread overview]
Message-ID: <20260812053905.70799-1-abe@maticrobots.com> (raw)
In-Reply-To: <5pH8Hvm9Tn-0PY-swUeCwA@nvidia.com>
On Fri, Jul 31, 2026 at 04:13:31PM +0900, Mikko Perttunen wrote:
> I don't think this is a problem, as the device tree is supposed to
> describe the visible hardware.
Fair, I noticed it when testing, so I figured I should bring it up.
> Why do we need to consider cs-gpios? If a device has a cs-gpio,
> whatever we program here wouldn't reach the device.
To maintain signal for signal backwards compatibility, I kept the
(unused) native CS lines low. Nothing should be using those lines, so I
will drop it in v3 unless you say otherwise.
> The if condition is also very difficult to read -- please use multiple
> if statements and normal error handling patterns.
Will fix in V3.
Thanks,
Abe
prev parent reply other threads:[~2026-08-12 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:01 [PATCH v2] spi: tegra114: initialize native chip selects inactive Abraham Zukor
2026-07-31 7:13 ` Mikko Perttunen
2026-08-12 5:38 ` Abraham Zukor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812053905.70799-1-abe@maticrobots.com \
--to=abe@maticrobots.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox