From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mohamed Anis Ben Azza <benazzaanis783@gmail.com>
Cc: Marc Dietrich <marvin24@gmx.de>,
linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org,
ac100@lists.launchpad.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: nvec: kbd: bound keycode table lookups
Date: Fri, 20 Nov 2026 08:22:31 +0100 [thread overview]
Message-ID: <2026112023-visiting-gravity-2945@gregkh> (raw)
In-Reply-To: <20261111230134.200561-1-benazzaanis783@gmail.com>
On Thu, Nov 12, 2026 at 01:01:34AM +0200, Mohamed Anis Ben Azza wrote:
> nvec_keys_notifier() indexes code_tabs[_size][code] using values taken
> directly from the embedded controller's event message without checking
> them against the tables:
>
> - _size is a 2-bit field (0..3) from the message header, but code_tabs[]
> only has entries for NVEC_2BYTES and NVEC_3BYTES. NVEC_VAR_SIZE is
> rejected, but the reserved encoding 3 is not, so code_tabs[3] reads a
> pointer past the end of the array and then dereferences it.
>
> - code is msg[1] & 0x7f (0..127), but code_tab_102us[] has only 126
> entries and extcode_tab_us102[] only 110, so scancodes at or above
> those sizes read past the end of the tables.
>
> Reject any size encoding without a table and any scancode beyond the
> end of the selected table, dropping the event as is already done for
> the power button.
>
> This only matters for an EC that sends malformed or out-of-spec
> events, so it is a robustness fix rather than a security issue.
>
> The issue was found and the fix drafted with the help of an AI coding
> assistant (Claude). It was compile-tested with
> ARCH=arm LLVM=1 tegra_defconfig + MFD_NVEC/KEYBOARD_NVEC at W=1 with no
> new warnings, and the lookup logic was exercised in a userspace harness
> under AddressSanitizer for all 4 size encodings x 256 scancodes: the old
> code reports a global-buffer-overflow, the new code none. It has not
> been tested on real Tegra/AC100 hardware.
>
> Fixes: 32890b983086 ("Staging: initial version of the nvec driver")
> Signed-off-by: Mohamed Anis Ben Azza <benazzaanis783@gmail.com>
> ---
> drivers/staging/nvec/nvec_kbd.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
Please read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
prev parent reply other threads:[~2026-11-20 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 23:01 [PATCH] staging: nvec: kbd: bound keycode table lookups Mohamed Anis Ben Azza
2026-11-15 22:00 ` Marc Dietrich
2026-11-20 7:22 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026112023-visiting-gravity-2945@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ac100@lists.launchpad.net \
--cc=benazzaanis783@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox