From: Federico Vaga <federico.vaga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
a.sappia-197Af0g7QoUlk5EcyZIkJQ@public.gmane.org,
puria.nafisi-yFROiS3d6cY@public.gmane.org,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: How to correctly use spi_slave_tegra
Date: Thu, 15 Nov 2012 20:10:21 +0100 [thread overview]
Message-ID: <2060607.hJW5X3vV4O@number-5> (raw)
In-Reply-To: <50A538DA.2010906-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> That's a very old kernel. I doubt anyone really remembers much about the
> NVIDIA custom code we applied to it. Are you sure you have 2.6.32
> anyway; the only copy of NVIDIA's 2.6.32-based kernel I have doesn't
> include the Tegra SPI slave driver as far as I can tell.
Probably we can work with 3.1. But the question it is the same because both
spi_slave_tegra drivers have few difference
> I'd recommend at least upgrading to the most recent NVIDIA downstream
> kernel so that people still remember the code.
Assuming that spi_slave_tegra is working perfectly. Nobody developed something
with it?
> I should recommend switching to an upstream kernel, but we don't have
> any SPI slave driver there at all, nor yet Colibri support, so that
> wouldn't be much use, unless you want to upstream the support yourself...
I think that it is not acceptable for upstream because spi_slave_tegra is
using the SPI framework in the "wrong" way, because the SPI framework support
only master controller. We should think about extending the SPI framework for
slave support (maybe it is an easy job, I don't know). But if it is an
unwanted features it could be an useless work. We want to use (try) the
controller in the slave mode due to special condition on our hardware. If we
can use the master mode we are happier :)
> > As I understand:
> > - obviously I must configure SPI before master start communication
> > - speed_hz must be the same of the master
> > - I must use spi_async (spi_sync can freeze the driver)
> > - Only messages with single transfer. If the master sends messages with
> > multiple transfer, I must receive them with a single transfer
> > - I have two callback. the message->complete from the SPI framework and
> > the
> > spi_tegra_register_callback from the spi_slave_tegra
>
> From a very very very brief look at ouor android-tegra-nv-3.1 branch,
> your understanding sounds at least reasonable even if not correct!
I will update you when I can test on hardware
--
Federico Vaga
prev parent reply other threads:[~2012-11-15 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 20:08 How to correctly use spi_slave_tegra Federico Vaga
2012-11-15 18:47 ` Stephen Warren
[not found] ` <50A538DA.2010906-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-15 19:04 ` Laxman Dewangan
[not found] ` <50A53CB7.1090705-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-15 19:19 ` Federico Vaga
2012-11-15 19:41 ` Federico Vaga
2012-11-15 23:23 ` Laxman Dewangan
[not found] ` <50A57959.1040208-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-15 23:37 ` Federico Vaga
2012-11-15 19:10 ` Federico Vaga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2060607.hJW5X3vV4O@number-5 \
--to=federico.vaga-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=a.sappia-197Af0g7QoUlk5EcyZIkJQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=puria.nafisi-yFROiS3d6cY@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).