From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v3 06/10] ASoC: tegra: add Tegra186 based DSPK driver Date: Thu, 20 Feb 2020 15:10:10 +0000 Message-ID: <21f89564-2e04-7d06-bb07-5fa488d9ee8f@nvidia.com> References: <1582180492-25297-1-git-send-email-spujar@nvidia.com> <1582180492-25297-7-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1582180492-25297-7-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 20/02/2020 06:34, Sameer Pujar wrote: > The Digital Speaker Controller (DSPK) converts the multi-bit Pulse Code > Modulation (PCM) audio input to oversampled 1-bit Pulse Density Modulation > (PDM) output. From the signal flow perpsective, the DSPK can be viewed as > a PDM transmitter that up-samples the input to the desired sampling rate > by interpolation then converts the oversampled PCM input to the desired > 1-bit output via Delta Sigma Modulation (DSM). > > This patch registers DSPK component with ASoC framework. The component > driver exposes DAPM widgets, routes and kcontrols for the device. The DAI > driver exposes DSPK interfaces, which can be used to connect different > components in the ASoC layer. Makefile and Kconfig support is added to > allow to build the driver. The DSPK devices can be enabled in the DT via > "nvidia,tegra186-dspk" compatible binding. This driver can be used > on Tegra194 chip as well. > > Signed-off-by: Sameer Pujar > --- > sound/soc/tegra/Kconfig | 13 + > sound/soc/tegra/Makefile | 2 + > sound/soc/tegra/tegra186_dspk.c | 510 ++++++++++++++++++++++++++++++++++++++++ > sound/soc/tegra/tegra186_dspk.h | 73 ++++++ > 4 files changed, 598 insertions(+) > create mode 100644 sound/soc/tegra/tegra186_dspk.c > create mode 100644 sound/soc/tegra/tegra186_dspk.h Aside from Randy's comment ... Reviewed-by: Jon Hunter Cheers Jon -- nvpublic