From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: tegra: add support for CIF programming Date: Tue, 21 Jan 2020 19:04:20 +0300 Message-ID: <229def08-6bd4-30d7-056b-92329e48c699@gmail.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-3-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 21.01.2020 07:41, Sameer Pujar пишет: > > On 1/20/2020 9:28 PM, Dmitry Osipenko wrote: >> External email: Use caution opening links or attachments >> >> >> Hello Sameer, >> >> 20.01.2020 17:23, Sameer Pujar пишет: >> >> [snip] >> >>> Tegra30 and Tegra124 have an identical CIF programming helper function. >> [snip] >> >>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT  24 >>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US        0x3f >>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK   >>> (TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US << >>> TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT) >>> - >>> -/* Channel count minus 1 */ >>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT   24 >>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US 7 >>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK    >>> (TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US << >>> TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT) >> The AUDIOCIF_CTRL bitfields are not the same on T30 and T124, why are >> you claiming that programming is identical? Have you actually tried to >> test these patches on T30? > > Oh yes! seems like I overlooked the macro values. Thanks for pointing > this. I will retain separate CIF function for Tegra30. > I do not have a Tegra30 board with me and hence could not test anything > specific to it apart from build sanity. > If someone can help me test I would really appreciate. > I'll help with the testing once all obvious problems will be fixed.