From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent Date: Fri, 12 Jun 2020 17:15:39 +0300 Message-ID: <2707086c-e604-d0d6-66fa-072e5844e923@gmail.com> References: <20200611190758.172605-1-iamkeyur96@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200611190758.172605-1-iamkeyur96-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Keyur Patel , Thierry Reding , Jonathan Hunter , Peter De Schrijver , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 11.06.2020 22:07, Keyur Patel пишет: > Since the commit 7723f4c ("driver core: platform: Add an error message > to platform_get_irq*()") platform_get_irq() started issuing an error message. > Thus, there is no need to have the same in the driver. > > Signed-off-by: Keyur Patel > --- > drivers/memory/tegra/mc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > index ec8403557ed4..f519c0987485 100644 > --- a/drivers/memory/tegra/mc.c > +++ b/drivers/memory/tegra/mc.c > @@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev) > } > > mc->irq = platform_get_irq(pdev, 0); > - if (mc->irq < 0) { > - dev_err(&pdev->dev, "interrupt not specified\n"); > + if (mc->irq < 0) > return mc->irq; > - } > > WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n"); > > Reviewed-by: Dmitry Osipenko