public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jonathan Hunter
	<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v1 1/3] soc/tegra: fuse: Fix reading registers using DMA on Tegra20
Date: Tue, 26 Sep 2017 01:35:37 +0300	[thread overview]
Message-ID: <27dadd0335aac71c9d4d613c33a6a1d0a285afa4.1506378772.git.digetx@gmail.com> (raw)

DMA config is incorrect, because of it DMA transfer is never issued and
tegra20_fuse_read() always returns 0x0.

Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/soc/tegra/fuse/fuse-tegra.c   | 1 +
 drivers/soc/tegra/fuse/fuse-tegra20.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
index b7c552e3133c..73a3a2c74021 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra.c
@@ -132,6 +132,7 @@ static int tegra_fuse_probe(struct platform_device *pdev)
 
 	/* take over the memory region from the early initialization */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	fuse->phys = res->start;
 	fuse->base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(fuse->base))
 		return PTR_ERR(fuse->base);
diff --git a/drivers/soc/tegra/fuse/fuse-tegra20.c b/drivers/soc/tegra/fuse/fuse-tegra20.c
index 294413a969a0..a33f48c06771 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra20.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra20.c
@@ -59,7 +59,7 @@ static u32 tegra20_fuse_read(struct tegra_fuse *fuse, unsigned int offset)
 
 	mutex_lock(&fuse->apbdma.lock);
 
-	fuse->apbdma.config.src_addr = fuse->apbdma.phys + FUSE_BEGIN + offset;
+	fuse->apbdma.config.src_addr = fuse->phys + FUSE_BEGIN + offset;
 
 	err = dmaengine_slave_config(fuse->apbdma.chan, &fuse->apbdma.config);
 	if (err)
@@ -119,6 +119,7 @@ static int tegra20_fuse_probe(struct tegra_fuse *fuse)
 	fuse->apbdma.config.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
 	fuse->apbdma.config.src_maxburst = 1;
 	fuse->apbdma.config.dst_maxburst = 1;
+	fuse->apbdma.config.direction = DMA_DEV_TO_MEM;
 
 	init_completion(&fuse->apbdma.wait);
 	mutex_init(&fuse->apbdma.lock);
-- 
2.14.1

             reply	other threads:[~2017-09-25 22:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 22:35 Dmitry Osipenko [this message]
     [not found] ` <27dadd0335aac71c9d4d613c33a6a1d0a285afa4.1506378772.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-25 22:35   ` [PATCH v1 2/3] ARM: dts: tegra20: Add DMA phandle to 'fuse' node Dmitry Osipenko
     [not found]     ` <8268404736bd3c254f8516109465bb8db4739c33.1506378772.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26 20:54       ` Jon Hunter
     [not found]         ` <c0776324-95e9-9e4c-00ac-a415cb1cd9e3-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-26 21:25           ` Jon Hunter
     [not found]             ` <ce5c5242-8530-4b0e-dd2d-0a9ef1ac005e-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-26 21:54               ` Dmitry Osipenko
     [not found]                 ` <a5db226b-b177-f52f-3a53-5e65f5a27243-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26 22:10                   ` Jon Hunter
     [not found]                     ` <59edd5b4-754a-93eb-8529-a5ff140c1a37-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-26 22:31                       ` Dmitry Osipenko
     [not found]                         ` <f8a0e6ab-8485-b60b-64ef-21574395b4d1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26 22:40                           ` Dmitry Osipenko
2017-09-25 22:35   ` [PATCH v1 3/3] soc/tegra: fuse: Explicitly request DMA channel from APB DMA driver Dmitry Osipenko
2017-09-26 14:08   ` [PATCH v1 1/3] soc/tegra: fuse: Fix reading registers using DMA on Tegra20 Jon Hunter
     [not found]     ` <87d33561-d959-7444-552d-7226adf29eb4-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-26 16:08       ` Stephen Warren
     [not found]         ` <d6bd8251-421e-5bc9-ce99-2b6aee4640ce-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2017-09-26 17:31           ` Dmitry Osipenko
     [not found]             ` <9921a66d-90f0-5a69-2da3-dc2c355eb86a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26 20:53               ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27dadd0335aac71c9d4d613c33a6a1d0a285afa4.1506378772.git.digetx@gmail.com \
    --to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox