From: Jon Hunter <jonathanh@nvidia.com>
To: Sumit Gupta <sumitg@nvidia.com>,
krzk@kernel.org, treding@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Cc: bbasu@nvidia.com
Subject: Re: [PATCH v3] memory: tegra: add multi-socket support to the memory interconnect
Date: Tue, 7 Jul 2026 12:00:49 +0100 [thread overview]
Message-ID: <294fb73c-f368-4737-9450-16d6160067cb@nvidia.com> (raw)
In-Reply-To: <20260626131423.3986998-1-sumitg@nvidia.com>
On 26/06/2026 14:14, Sumit Gupta wrote:
> Add support for representing each memory-controller instance (one
> per NUMA node / socket) as its own interconnect (ICC) provider,
> with its own MC client nodes, to match the hardware topology on
> multi-socket Tegra SoCs.
>
> Use the NUMA node ID to make client IDs globally unique across
> per-socket providers, since the ICC framework allocates node IDs
> from a single global IDR. Per-socket MC and EMC node names are
> also derived from dev_name() so they match the corresponding
> debugfs subdirectory. On single-socket platforms (NUMA_NO_NODE)
> the existing client IDs and node-name strings are preserved.
>
> Each socket's MC and EMC therefore get their own debugfs
> subdirectory under /sys/kernel/debug/{mc,emc}/. The parent
> directories are created on first probe.
>
> Bandwidth requests from MC clients in a socket are routed to
> that socket's local BPMP.
>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> v2[2] -> v3:
> - Reduce per-socket shift to 12 bits to keep composed ICC node
> IDs below ICC_DYN_ID_START.
>
> v1[1] -> v2:
> - Mutex protected lazy creation of the mc/emc debugfs parent.
> - Rename {mc|emc}_debugfs_root to tegra_{mc|emc}_debugfs_root.
>
> [1] https://lore.kernel.org/lkml/20260521140546.3023819-1-sumitg@nvidia.com/
> [2] https://lore.kernel.org/lkml/20260602132314.486066-1-sumitg@nvidia.com/
> ---
> drivers/memory/tegra/mc.c | 40 ++++++++++++++++-----
> drivers/memory/tegra/mc.h | 37 +++++++++++++++++++
> drivers/memory/tegra/tegra186-emc.c | 55 ++++++++++++++++++++++++-----
> 3 files changed, 115 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> index ec80ea9cc173..51ad0d3e48d4 100644
> --- a/drivers/memory/tegra/mc.c
> +++ b/drivers/memory/tegra/mc.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2014-2026 NVIDIA CORPORATION. All rights reserved.
> */
>
> +#include <linux/cleanup.h>
> #include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> @@ -10,6 +11,7 @@
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/mutex.h>
There is a conflict here with the latest -next and so we need to rebase
this. Otherwise ...
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2026-07-07 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 13:14 [PATCH v3] memory: tegra: add multi-socket support to the memory interconnect Sumit Gupta
2026-07-07 11:00 ` Jon Hunter [this message]
2026-07-08 11:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=294fb73c-f368-4737-9450-16d6160067cb@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox