From: Shanker Donthineni <sdonthineni@nvidia.com>
To: Akhil R <akhilrajeev@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "andi.shyti@kernel.org" <andi.shyti@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v2] i2c: tegra: Fix failure during probe deferral cleanup
Date: Mon, 17 Jul 2023 12:25:37 -0500 [thread overview]
Message-ID: <2a05decb-de03-6fb6-a436-d0e483553d03@nvidia.com> (raw)
In-Reply-To: <SJ1PR12MB6339382ED219ED363041659FC03BA@SJ1PR12MB6339.namprd12.prod.outlook.com>
On 7/17/23 12:15, Akhil R wrote:
>> If the driver fails to obtain a DMA channel, it will initiate cleanup
>> and try to release the DMA channel that couldn't be retrieved. This will
>> cause a crash because the cleanup will try to dereference an ERR_PTR()-
>> encoded error code.
>>
>> However, there's nothing to clean up at this point yet, so we can avoid
>> this by simply resetting the DMA channel to NULL instead of storing the
>> error code.
>>
>> Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and TX")
>> Signed-off-by: Thierry Reding mailto:treding@nvidia.com
>
> This fixed the crash issue seen when there is no dmas property in the device tree.
>
> Tested-by: Akhil R <akhilrajeev@nvidia.com>
The kernel crash issue has been fixed with ACPI based kernel on T241 (Server) platform.
Tested-by: Shanker Donthineni <sdonthineni@nvidia.com>
next prev parent reply other threads:[~2023-07-17 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 17:15 [PATCH v2] i2c: tegra: Fix failure during probe deferral cleanup Akhil R
2023-07-17 17:25 ` Shanker Donthineni [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-07 13:26 Thierry Reding
2023-07-20 15:42 ` Akhil R
2023-07-25 16:25 ` Thierry Reding
2023-07-25 21:34 ` Andi Shyti
2023-07-27 15:05 ` Thierry Reding
2023-07-27 19:57 ` Andi Shyti
2023-08-14 13:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a05decb-de03-6fb6-a436-d0e483553d03@nvidia.com \
--to=sdonthineni@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).