From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v1] drm/tegra: Fix gpiod_get_from_of_node() regression Date: Wed, 10 Jul 2019 00:04:15 +0300 Message-ID: <2a4c63f8-9ea7-a017-57f9-1dec0f178a79@gmail.com> References: <20190705151139.19032-1-digetx@gmail.com> <9425f0e8-36ec-76cb-b177-fa486fcafc19@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <9425f0e8-36ec-76cb-b177-fa486fcafc19@nvidia.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jon Hunter , Thierry Reding Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 09.07.2019 19:27, Jon Hunter пишет: > > On 05/07/2019 16:11, Dmitry Osipenko wrote: >> That function now returns ERR_PTR instead of NULL if "hpd-gpio" is not >> present in device-tree. The offending patch missed to adapt the Tegra's >> DRM driver for the API change. >> >> Fixes: 025bf37725f1 ("gpio: Fix return value mismatch of function gpiod_get_from_of_node()") >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/tegra/output.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c >> index 274cb955e2e1..471d33809cd4 100644 >> --- a/drivers/gpu/drm/tegra/output.c >> +++ b/drivers/gpu/drm/tegra/output.c >> @@ -126,8 +126,12 @@ int tegra_output_probe(struct tegra_output *output) >> "nvidia,hpd-gpio", 0, >> GPIOD_IN, >> "HDMI hotplug detect"); >> - if (IS_ERR(output->hpd_gpio)) >> - return PTR_ERR(output->hpd_gpio); >> + if (IS_ERR(output->hpd_gpio)) { >> + if (PTR_ERR(output->hpd_gpio) == -ENOENT) >> + output->hpd_gpio = NULL; >> + else >> + return PTR_ERR(output->hpd_gpio); >> + } >> >> if (output->hpd_gpio) { >> err = gpiod_to_irq(output->hpd_gpio); >> > > Acked-by: Jon Hunter Thanks!