From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sumit Gupta <sumitg@nvidia.com>,
treding@nvidia.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Cc: bbasu@nvidia.com
Subject: Re: [PATCH] memory: tegra: add multi-socket support to the memory interconnect
Date: Wed, 27 May 2026 14:55:53 +0200 [thread overview]
Message-ID: <2caba07a-511e-453c-8e1e-f2b07b84a096@kernel.org> (raw)
In-Reply-To: <20260521140546.3023819-1-sumitg@nvidia.com>
On 21/05/2026 16:05, Sumit Gupta wrote:
> - err = icc_link_create(node, TEGRA_ICC_MC);
> + err = tegra_mc_icc_link_create(node, node_id, TEGRA_ICC_MC);
> if (err)
> goto remove_nodes;
>
> @@ -957,7 +969,13 @@ static int tegra_mc_probe(struct platform_device *pdev)
> if (IS_ERR(mc->regs))
> return PTR_ERR(mc->regs);
>
> - mc->debugfs.root = debugfs_create_dir("mc", NULL);
> + if (!mc_debugfs_root)
That's a probe path and you created a singletone. Looks like preventing
async probing for no real reason.
I am very against singletons and debugfs does not look like justified
exception.
> + mc_debugfs_root = debugfs_create_dir("mc", NULL);
> +
> + if (dev_to_node(mc->dev) == NUMA_NO_NODE)
> + mc->debugfs.root = mc_debugfs_root;
> + else
> + mc->debugfs.root = debugfs_create_dir(dev_name(mc->dev), mc_debugfs_root);
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-27 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 14:05 [PATCH] memory: tegra: add multi-socket support to the memory interconnect Sumit Gupta
2026-05-27 12:55 ` Krzysztof Kozlowski [this message]
2026-05-27 14:21 ` Sumit Gupta
2026-05-27 14:46 ` Krzysztof Kozlowski
2026-05-28 11:56 ` Thierry Reding
2026-05-28 12:20 ` Krzysztof Kozlowski
2026-05-28 13:05 ` Thierry Reding
2026-05-29 9:25 ` Sumit Gupta
2026-05-29 15:23 ` Thierry Reding
2026-06-02 11:49 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2caba07a-511e-453c-8e1e-f2b07b84a096@kernel.org \
--to=krzk@kernel.org \
--cc=bbasu@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox