From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Benjamin Bara <bbara93@gmail.com>, Wolfram Sang <wsa@kernel.org>,
Lee Jones <lee@kernel.org>,
rafael.j.wysocki@intel.com
Cc: peterz@infradead.org, jonathanh@nvidia.com,
richard.leitner@linux.dev, treding@nvidia.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org,
Benjamin Bara <benjamin.bara@skidata.com>
Subject: Re: [PATCH v4 3/4] mfd: tps6586x: use devm-based power off handler
Date: Thu, 13 Apr 2023 23:36:59 +0300 [thread overview]
Message-ID: <2df6f002-dcf8-1073-d0b5-a9843103096a@collabora.com> (raw)
In-Reply-To: <20230327-tegra-pmic-reboot-v4-3-b24af219fb47@skidata.com>
On 4/13/23 10:46, Benjamin Bara wrote:
> +static int tps6586x_power_off_handler(struct sys_off_data *data)
> {
> - if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
> - return;
> + struct device *tps6586x_dev = data->cb_data;
> + int ret;
> +
> + ret = tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT);
> + if (ret)
> + return ret;
>
> - tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SLEEP_MODE_BIT);
> + return tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SLEEP_MODE_BIT);
Handlers must return NOTIFY_DONE or notifier_from_errno(). Sorry for
missing this previously.
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-04-13 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 7:46 [PATCH v4 0/4] mfd: tps6586x: register restart handler Benjamin Bara
2023-04-13 7:46 ` [PATCH v4 1/4] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-04-13 7:46 ` [PATCH v4 2/4] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-04-13 19:51 ` Wolfram Sang
2023-04-13 7:46 ` [PATCH v4 3/4] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-04-13 20:36 ` Dmitry Osipenko [this message]
2023-04-14 6:15 ` Benjamin Bara
2023-04-24 10:42 ` Dmitry Osipenko
2023-04-24 12:07 ` Benjamin Bara
2023-04-13 7:46 ` [PATCH v4 4/4] mfd: tps6586x: register restart handler Benjamin Bara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df6f002-dcf8-1073-d0b5-a9843103096a@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=jonathanh@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox