From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Liang He <windhl@126.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] memory/tegra: Add missing of_node_get() in tegra_emc_find_node_by_ram_code
Date: Wed, 22 Jun 2022 10:41:28 +0200 [thread overview]
Message-ID: <2f3e843e-b72b-ee71-7465-b2b6c8d51b0d@linaro.org> (raw)
In-Reply-To: <20220622042824.4094625-1-windhl@126.com>
On 22/06/2022 06:28, Liang He wrote:
> of_find_node_by_name() will decrease the refcount of its first arg and
> we need to add a of_node_put() to keep refcount balance.
>
> Besides, during the 'for' loop execution, the refcount of 'np' will be
> automatically increased and decreased. There is no need to call
> of_node_put() again.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/memory/tegra/tegra20-emc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
The patch was not even compiled... I consider it harmful approach. NAK.
See: https://lwn.net/Articles/854645/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-22 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:28 [PATCH] memory/tegra: Add missing of_node_get() in tegra_emc_find_node_by_ram_code Liang He
2022-06-22 6:50 ` Krzysztof Kozlowski
2022-06-22 6:56 ` Liang He
2022-06-22 8:35 ` kernel test robot
2022-06-22 8:41 ` Krzysztof Kozlowski [this message]
2022-06-22 8:49 ` Liang He
2022-06-22 9:08 ` Krzysztof Kozlowski
2022-06-22 9:09 ` Krzysztof Kozlowski
2022-06-22 9:20 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f3e843e-b72b-ee71-7465-b2b6c8d51b0d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox