Re: [PATCH] staging:nvec:nvec - Fix for typo in comment to function tegra_nvec_remove().

From: Marc Dietrich <marvin24@gmx.de>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Julian Andres Klode <jak@jak-linux.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	ac100@lists.launchpad.net
Subject: Re: [PATCH] staging:nvec:nvec - Fix for typo in comment to function tegra_nvec_remove().
Date: Tue, 26 May 2015 13:47:17 +0200	[thread overview]
Message-ID: <3269524.kNMZGSE8Ks@fb07-iapwap2> (raw)
In-Reply-To: <1432586801-5879-1-git-send-email-shailendra.capricorn@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1142 bytes --]

Hi Shailendra,

you should fill the patch description with something, even if trivial, and 
trim the subject line a bit, e.g.

---
staging: nvec: fix typo in comment (all lowercase, no full stop at the end)

Fix spelling error in comment in function tegra_nvec_remove.

S-o-b
-----

Thanks,

Marc

Am Dienstag, 26. Mai 2015, 02:16:41 schrieb Shailendra Verma:
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 1bdc8d0..164634d 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -916,7 +916,7 @@ static int tegra_nvec_remove(struct platform_device
> *pdev) nvec_unregister_notifier(nvec, &nvec->nvec_status_notifier);
>  	cancel_work_sync(&nvec->rx_work);
>  	cancel_work_sync(&nvec->tx_work);
> -	/* FIXME: needs check wether nvec is responsible for power off */
> +	/* FIXME: needs check whether nvec is responsible for power off */
>  	pm_power_off = NULL;
> 
>  	return 0;

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel