From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor
Date: Fri, 11 Sep 2026 15:48:19 +0100 [thread overview]
Message-ID: <353be5ea-4845-42dd-a902-430f0ed37348@nvidia.com> (raw)
In-Reply-To: <aoQ4vGb2-FwwXss9@orome>
On 18/08/2026 11:54, Thierry Reding wrote:
> On Mon, Aug 17, 2026 at 03:41:31PM +0100, Jon Hunter wrote:
>>
>> On 17/08/2026 15:32, Thierry Reding wrote:
>>> From: Thierry Reding <treding@nvidia.com>
>>>
>>> The built-in RTC is mostly useful for testing suspend/resume cycles.
>>>
>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>>> ---
>>> arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
>>> index c4ba3322ed9a..113ecf297378 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
>>> @@ -13,6 +13,12 @@ chosen {
>>> stdout-path = "serial0:115200n8";
>>> };
>>> + bus@0 {
>>> + rtc@c2c0000 {
>>> + status = "okay";
>>> + };
>>> + };
>>> +
>>
>>
>> Any reason we should not just enable in tegra264.dtsi by default? I see that
>> we do that for tegra234.
>
> This is more of a development type of option and not everybody may want
> to have it enabled, especially since it's not always hooked up to do
> anything useful. We commonly use it on the devkit for suspend/resume
> testing, so it's useful there, but even then there's usually another RTC
> on a PMIC or something that's considered the primary one.
>
> So in production I suspect people may not want to enable the built-in
> RTC. If we enabled it by default, then people would have to explicitly
> disable it again.
>
> I don't feel very strongly either way, and I could easily be swayed.
I would be good to get this added. I don't have strong feelings either
way. So ...
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks!
Jon
--
nvpublic
prev parent reply other threads:[~2026-09-11 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 14:32 [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor Thierry Reding
2026-08-17 14:41 ` Jon Hunter
2026-08-18 10:54 ` Thierry Reding
2026-09-11 14:48 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353be5ea-4845-42dd-a902-430f0ed37348@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox