From: Baolu Lu <baolu.lu@linux.intel.com>
To: Minjie Du <duminjie@vivo.com>,
Thierry Reding <thierry.reding@gmail.com>,
Krishna Reddy <vdumpa@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"open list:TEGRA IOMMU DRIVERS" <linux-tegra@vger.kernel.org>,
"open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Cc: baolu.lu@linux.intel.com, opensource.kernel@vivo.com,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
Date: Fri, 14 Jul 2023 10:57:38 +0800 [thread overview]
Message-ID: <362e4343-dcf1-58fc-7ac9-756c65bb0df6@linux.intel.com> (raw)
In-Reply-To: <20230713072825.10348-1-duminjie@vivo.com>
On 2023/7/13 15:28, Minjie Du wrote:
> debugfs_create_file() will return early if smmu->debugfs is an error
> pointer, so an extra error check is not needed.
>
> Signed-off-by: Minjie Du<duminjie@vivo.com>
> Acked-by: Thierry Reding<treding@nvidia.com>
Greg keeps reminding that no error branch for debugfs, so
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
next prev parent reply other threads:[~2023-07-14 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 7:28 [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() Minjie Du
2023-07-14 2:31 ` Baolu Lu
[not found] ` <SG2PR06MB5288E9FC9B6EA21E20BB011EAE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
2023-07-14 2:50 ` 回复: " Baolu Lu
2023-07-14 2:57 ` Baolu Lu [this message]
[not found] ` <SG2PR06MB5288ED578DB3CE7DA2B25AB5AE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
2023-07-14 8:41 ` Thierry Reding
-- strict thread matches above, loose matches on Subject: below --
2023-07-14 9:02 Minjie Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=362e4343-dcf1-58fc-7ac9-756c65bb0df6@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=duminjie@vivo.com \
--cc=iommu@lists.linux.dev \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).