From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBB1C433DF for ; Fri, 24 Jul 2020 16:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66A432067D for ; Fri, 24 Jul 2020 16:57:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="br36lvHx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgGXQ5b (ORCPT ); Fri, 24 Jul 2020 12:57:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbgGXQ5a (ORCPT ); Fri, 24 Jul 2020 12:57:30 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBCA1C0619D3 for ; Fri, 24 Jul 2020 09:57:30 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id l6so4787961plt.7 for ; Fri, 24 Jul 2020 09:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SippstkTYnPDmGe0JxL9e/Dl+xQ0faDafFxLncOD7Ao=; b=br36lvHxMUXbASakMGxCauQBtM/0DE/9ofTfq23grxRs4+mKeN22H0iLcjaKrmRYrk eqe9TSXK8XUP2dX+E8wAcOCLctRW7VpFX1tHG4LeZZNduDynrf/1uzCovEoiMWHSW8Z/ cE5VfummJI5qf06tHYUXzyFFXpXU/nN2cYTQK9ugzp4/JDzIwTBK05OKy9FDulZAwvo/ fYqjKzIyiUoQR8+c72opobby+Fq3CEpMkF/5Wqn2/sw71HipYyGKNsjPFIcUYAqAUE3U IaqrhIJuwe8GP8af7kL33+6UUt9zpyIIr6UCJOre8ZX7VriWWBdj4Ly+9imxHENELiLU /oeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SippstkTYnPDmGe0JxL9e/Dl+xQ0faDafFxLncOD7Ao=; b=OX567V10DuuhRiCKU/H40/c22wSDzdRWJAUmgrCu5I1G6fck0c9IdOX/ZhTaKWhOsq jvhxNlhf8UF7Fu1aFZq6o323i/w0ZYYHrIUsi4aJedwDtJKGdMIRJiXgm34ySQl02bFx U4PN9ksF+VAOpOxlPfnn6zv5KQeSO80Hd/igHxNB1P0xXQ88zwqnZX98ZGezd/DC3iwg sg12RN1zjxYxzmFyj5IyzaY2MNJJmDqGB7LZqPOKvNUZQOr9Y5Lew2Cv1I8ahUUD4/nA Y5Xm53eh5/7skp/Px201nN94pXTk2CqArzjyzWKLG6w8v1JDOgV6jvePOx7POdnq+i7f 3qmg== X-Gm-Message-State: AOAM533FnIvV+k8Q0UV3w6XJfMf1SEs8Jac6ji5/3sSfGPzsv7YronDd kbT111outbBvnp+8JTbDQa4= X-Google-Smtp-Source: ABdhPJyRV261+EXQENgsF9DvLK846Ax+Hrpv8hXlWJALuKLIjh5e5n2fcRpfTL+LNU1IGA0XS+5k/A== X-Received: by 2002:a17:90a:1345:: with SMTP id y5mr6469648pjf.68.1595609850248; Fri, 24 Jul 2020 09:57:30 -0700 (PDT) Received: from [192.168.0.109] ([1.186.115.27]) by smtp.gmail.com with ESMTPSA id m68sm6521015pje.24.2020.07.24.09.57.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 09:57:29 -0700 (PDT) Subject: Re: [PATCH v3] staging: nvec: change usage of slave to secondary To: Marc Dietrich Cc: Greg KH , p.zabel@pengutronix.de, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org References: <20200723151511.22193-1-bharadwaj.rohit8@gmail.com> <20200724043633.7755-1-bharadwaj.rohit8@gmail.com> <20200724082810.GA3977020@kroah.com> <34e6c906-7def-816d-a45d-03d366f32c61@gmail.com> From: Rohit K Bharadwaj Message-ID: <365fd26d-94b1-760e-48f5-bf8a85a90399@gmail.com> Date: Fri, 24 Jul 2020 22:27:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 24/07/20 10:06 pm, Marc Dietrich wrote: > > > On Fri, 24 Jul 2020, Marc Dietrich wrote: > >> Hi Rohit, >> >> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote: >> >>> On 24/07/20 1:58 pm, Greg KH wrote: >>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote: >>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote: >>>>>> changed usage of slave (deprecated) to secondary >>>>>> >>>>>> Signed-off-by: Rohit K Bharadwaj >>>>>> --- >>>>>> v3: change patch subject, add version history >>>>>> v2: add changelog text in body of mail >>>>>> v1: fix style issues by changing usage of slave to secondary >>>>>> >>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------ >>>>>>  1 file changed, 6 insertions(+), 6 deletions(-) >>>>>> >>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c >>>>>> index 360ec0407740..5d7b66719a39 100644 >>>>>> --- a/drivers/staging/nvec/nvec.c >>>>>> +++ b/drivers/staging/nvec/nvec.c >>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) >>>>>>      return IRQ_HANDLED; >>>>>>  } >>>>>> >>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec) >>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec) >>>>>>  { >>>>>>      u32 val; >>>>>> >>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) >>>>>>  } >>>>>> >>>>>>  #ifdef CONFIG_PM_SLEEP >>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec) >>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec) >>>>>>  { >>>>>>      disable_irq(nvec->irq); >>>>>>      writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); >>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) >>>>>>      platform_set_drvdata(pdev, nvec); >>>>>>      nvec->dev = dev; >>>>>> >>>>>> -    if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) { >>>>>> +    if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) { >>>>>>          dev_err(dev, "no i2c address specified"); >>>>>>          return -ENODEV; >>>>>>      } >> >> as Christoph said, please don't change this line. > > arr, I meant Dan of course ;-) Dear all, thank you so much for your inputs, I will try to make some other patch which will not break the driver (hopefully :p), or if you give me permission to submit this patch itself by just keeping this one line > if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) unchanged, and provided it does not break the driver by doing so, I would gladly make the changes and submit v4 of the patch.