From: Dmitry Osipenko <digetx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3] regulator: Make regulator_sync_voltage() usable by coupled regulators
Date: Fri, 22 Jan 2021 19:00:32 +0300 [thread overview]
Message-ID: <36d0dad5-d5dd-a089-b65b-0d476e639a98@gmail.com> (raw)
In-Reply-To: <20210122134045.GD6391@sirena.org.uk>
22.01.2021 16:40, Mark Brown пишет:
> On Fri, Jan 22, 2021 at 01:16:49AM +0300, Dmitry Osipenko wrote:
>
>> + /* balance only if there are regulators coupled */
>> + if (rdev->coupling_desc.n_coupled > 1) {
>> + ret = regulator_balance_voltage(rdev, PM_SUSPEND_ON);
>> + goto out;
>> + }
>> +
>> ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
>>
>> out:
>
> This would be clearer written as an if/else rather than using the goto.
>
I'll make v4, thanks.
prev parent reply other threads:[~2021-01-22 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 22:16 [PATCH v3] regulator: Make regulator_sync_voltage() usable by coupled regulators Dmitry Osipenko
2021-01-22 13:40 ` Mark Brown
2021-01-22 16:00 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d0dad5-d5dd-a089-b65b-0d476e639a98@gmail.com \
--to=digetx@gmail.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox