Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

Krzysztof Kozlowski
2026-03-03T14:54:25Z

On 03/03/2026 15:24, Jon Hunter wrote:
>
> On 02/03/2026 09:04, Krzysztof Kozlowski wrote:
>> On 02/03/2026 09:53, Sheetal . wrote:
>>> From: Sheetal <sheetal@nvidia.com>
>>>
>>> Tegra238 platforms use different clock rates for plla and
>>> plla_out0 clocks. Add Tegra238 support in the Tegra
>>> sound card driver to apply specific clock configurations.
>>>
>>> Signed-off-by: Aditya Bavanari <abavanari@nvidia.com>
>>> Signed-off-by: Sheetal <sheetal@nvidia.com>
>>> ---
>>> sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
>>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c
>>> index 94b5ab77649b..b6dadd6a3d3d 100644
>>> --- a/sound/soc/tegra/tegra_audio_graph_card.c
>>> +++ b/sound/soc/tegra/tegra_audio_graph_card.c
>>> @@ -1,5 +1,5 @@
>>> // SPDX-License-Identifier: GPL-2.0-only
>>> -// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
>>> +// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
>>
>> If updating it, you should rather drop it and use standard copyright.
>> This tag is not supported in kernel in general and I document it only
>> because it already spread all over.
>
> To be clear, you mean that 'SPDX-FileCopyrightText' is not supported?

Yes

> Where exactly do you document it for reference?

paste SPDX-FileCopyrightText in lore

>
> I know that Rob previously indicated that the 'Copyright' string in the
> above was redundant, but we have been told to keep this by the people at
> NVIDIA that specify how we should be formatting such tags when adding
> NVIDIA copyrights.

For the kernel, for most of us, most likely legally it is redundant and
Rob was right, but some companies insist on it and I don't want to
discuss with them, because they never use actual arguments except "my
legal told me I must do", so you can have it. That's not a problem.

Best regards,
Krzysztof