From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111EDEB64DD for ; Tue, 25 Jul 2023 20:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229448AbjGYULS (ORCPT ); Tue, 25 Jul 2023 16:11:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjGYULR (ORCPT ); Tue, 25 Jul 2023 16:11:17 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4651A1BE2 for ; Tue, 25 Jul 2023 13:11:16 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b9a828c920so14180451fa.1 for ; Tue, 25 Jul 2023 13:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690315874; x=1690920674; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7O+I1J6EYVnwgKOmqsEKJkPBtq7V8p2nt+4NZWxtynA=; b=InoYR4rNPb/gWV8AqP/ZiBjK21BiUoNM8z5z9DSMKMLeT/TPWYc7wpuWpqa1IFiTdG RQQ37OMc6Jt0yGEO+g5OjRTrZ5SKIYNurDDLUksosIbMnLQ/IXl1amHJ+f7810h1uYmu 2IJPM//OmJ6DuUXgCYeGig3Ph83RyfHhtuZHwlYwwh21ttcBfhh1qrlA2vB+jKdnHu1u swePhvo3T/+eXHF5btDs9TO1T1fH0qwfDIXbOjeLGBrzMlkVWno/kltdtGjJuaZYKfg2 giuUn7vpUpUnLEaSIwsUmKNM+bjmH4L62diPocYG9uKpd36ruoLG4Rb6MAi0ZCF5j7nW cP2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690315874; x=1690920674; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7O+I1J6EYVnwgKOmqsEKJkPBtq7V8p2nt+4NZWxtynA=; b=NXpnN+Fmx5+xfvvEZjheIju5eKgvcmBy8ZMeYWcYaOFsaWn7zGcTuMy63Joztdogxi jSdCiXaQpnRPv9sRZT9NeSJ36D9j7xZjCOtq2LjqilIxrzn7dmXLUwc91pHgwjPB7IAW 8MpVOlsv2iLiawlw7iwjaGotwR7BpgxoOr2XV+PeHY8K4vGKCV06dhhLL6H+Z/kCbh36 Ppoo3LTrChKs0wSnI1Ce4s6ZLqL3kPU3ah6wFvB8rzzUid8wFpjD8ROeThX8MpVJOdiW wKF4hcX3iy9Ah6z1WR3uQy/Nd5VSwnrjpMDMZ8l3WcsmHEVCuqnZM20tO/ioRQaY7cH8 Zhng== X-Gm-Message-State: ABy/qLYdvV3SkkhmAb7qyuQZNkFn3u3GmKb9eH67epn48XIIOtNx7A6l ddTzpcvjKfx5N1AvRjcteTTw4w== X-Google-Smtp-Source: APBJJlHKZs34yLkzenFmeMhBQoMJmhzcYqDMZBPkq1CsuwmUNRZdK+Cs/MSP4YQ7u5mQC2SN7m9NAw== X-Received: by 2002:a2e:808a:0:b0:2b3:4ea3:d020 with SMTP id i10-20020a2e808a000000b002b34ea3d020mr9317838ljg.17.1690315874458; Tue, 25 Jul 2023 13:11:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id n10-20020a170906164a00b00977cad140a8sm8601292ejd.218.2023.07.25.13.11.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 13:11:13 -0700 (PDT) Message-ID: <3a75c310-1eb3-ebcf-82e0-99897e5e37c9@linaro.org> Date: Tue, 25 Jul 2023 22:11:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [Patch RESEND 4/4] memory: tegra: make icc_set_bw return zero if BWMGR not supported Content-Language: en-US To: Jon Hunter , Sumit Gupta , treding@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Cc: bbasu@nvidia.com, talho@nvidia.com References: <20230621134400.23070-1-sumitg@nvidia.com> <20230621134400.23070-5-sumitg@nvidia.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 25/07/2023 20:29, Jon Hunter wrote: > Hi Krzysztof, > > On 21/06/2023 14:44, Sumit Gupta wrote: >> Return zero from icc_set_bw() to MC client driver if MRQ_BWMGR_INT >> is not supported by the BPMP-FW. Currently, 'EINVAL' is returned >> which causes error message in client drivers even when the platform >> doesn't support scaling. >> >> Signed-off-by: Sumit Gupta >> --- >> drivers/memory/tegra/tegra234.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/memory/tegra/tegra234.c b/drivers/memory/tegra/tegra234.c >> index bc73be7fe143..07aba301a173 100644 >> --- a/drivers/memory/tegra/tegra234.c >> +++ b/drivers/memory/tegra/tegra234.c >> @@ -951,7 +951,7 @@ static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst) >> return 0; >> >> if (!mc->bwmgr_mrq_supported) >> - return -EINVAL; >> + return 0; >> >> if (!mc->bpmp) { >> dev_err(mc->dev, "BPMP reference NULL\n"); >> @@ -998,7 +998,7 @@ static int tegra234_mc_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw, >> struct tegra_mc *mc = icc_provider_to_tegra_mc(p); >> >> if (!mc->bwmgr_mrq_supported) >> - return -EINVAL; >> + return 0; >> >> if (node->id == TEGRA_ICC_MC_CPU_CLUSTER0 || >> node->id == TEGRA_ICC_MC_CPU_CLUSTER1 || > > > I have also found that this change is needed for Linux v6.5 in order to > work with current BPMP firmware. Without this patch PCIe does not work > on Tegra234. We should probably also add the following fixes tag for > this patch ... > > Fixes: 9365bf006f53 ("PCI: tegra194: Add interconnect support in Tegra234") Thank you, I moved the commit to fixes branch. I hope other patches do not depend on the order (it was part of the patchset as 3/4 commit). Since I re-shuffled everything, I will send pull for current RC tomorrow, not today. Best regards, Krzysztof