From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver Date: Mon, 10 Feb 2020 16:45:05 +0530 Message-ID: <3c19ef99-8051-76f7-a4d6-0d61182fe6e4@nvidia.com> References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-7-git-send-email-spujar@nvidia.com> <75a63cb3-7d79-7216-6791-3cec57464cd9@nvidia.com> <847f4512-7118-e087-1004-685e476e11d8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <847f4512-7118-e087-1004-685e476e11d8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 2/7/2020 11:52 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 07.02.2020 14:26, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> On 2/6/2020 10:45 PM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 30.01.2020 13:33, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> +static const struct dev_pm_ops tegra186_dspk_pm_ops =3D { >>>> + SET_RUNTIME_PM_OPS(tegra186_dspk_runtime_suspend, >>>> + tegra186_dspk_runtime_resume, NULL) >>>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, >>>> + pm_runtime_force_resume) >>>> +}; >>> Could you please explain why drivers need the "late" system sleep? >> It was done to ensure core drivers are suspended first and defer the >> codec driver suspend > Suspend order is opposite to the drivers registration order. If there is > no real problem with that, then you should use the default suspend > level. Please don't try to fix a non-existent problems. No. This was done specifically to allow sound core to first stop any=20 ongoing audio activity during normal suspend and ensure a safe suspend=20 of AHUB devices by doing a LATE suspend.