From: Sameer Pujar <spujar@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
vkoul@kernel.org, thierry.reding@gmail.com,
dmaengine@vger.kernel.org
Cc: jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, mkumard@nvidia.com,
ldewangan@nvidia.com
Subject: Re: [PATCH 1/2] dt-bindings: dma: Add reg-names to nvidia,tegra210-adma
Date: Tue, 21 May 2024 16:28:49 +0530 [thread overview]
Message-ID: <40621383-dfd5-4438-8bfb-75edb92abba6@nvidia.com> (raw)
In-Reply-To: <918ca28c-2498-4c98-a257-33e828134087@kernel.org>
On 21-05-2024 14:54, Krzysztof Kozlowski wrote:
> On 20/05/2024 14:23, Sameer Pujar wrote:
>> From: Mohan Kumar <mkumard@nvidia.com>
>>
>> For Non-Hypervisor mode, Tegra ADMA driver requires the register
>> resource range to include both global and channel page in the reg
>> entry. For Hypervisor more, Tegra ADMA driver requires only the
>> channel page and global page range is not allowed for access.
>>
>> Add reg-names DT binding for Hypervisor mode to help driver to
>> differentiate the config between Hypervisor and Non-Hypervisor
>> mode of execution.
>>
>> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries.
Sorry about this, I will resend the series. Thanks.
next prev parent reply other threads:[~2024-05-21 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 12:23 [PATCH 0/2] Virtualization support for Tegra ADMA Sameer Pujar
2024-05-20 12:23 ` [PATCH 1/2] dt-bindings: dma: Add reg-names to nvidia,tegra210-adma Sameer Pujar
2024-05-21 9:24 ` Krzysztof Kozlowski
2024-05-21 10:58 ` Sameer Pujar [this message]
2024-05-20 12:23 ` [PATCH 2/2] dmaengine: tegra210-adma: Add support for ADMA virtualization Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40621383-dfd5-4438-8bfb-75edb92abba6@nvidia.com \
--to=spujar@nvidia.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).