From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011071.outbound.protection.outlook.com [52.101.52.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 371401A6810 for ; Tue, 3 Mar 2026 05:02:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.71 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772514179; cv=fail; b=Sth0ha00UzTy6pwDKV5eotdt5fMFGCdp6X5Ev0w2ym5ooS2l0D0hh33+UVRed5Yr3DQ6fepALHMQd0Uzl+IIc2zk82AH4wsUf2pMh5atsnjfXXFSjEeK9W+UPUPTvt8mONqp4t7kQqjov659Ctra8WwtKnzCqsi4eVNH7OZfHyg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772514179; c=relaxed/simple; bh=BNqueaNXffFBhtmWntvreLzXKmOr5BOnAt4jbhbd1HI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ErqyBjDOQ1IlGpjS2Y2RcGGfnQgaYfGCnD1H5EQSL5Eh8Ww56UzvblnUuSCa0fQBuV0TaUdTkoqsKgnia6yS+LSDgPy3pQRbEVK9Sdbqwf0Utj7bhXd0M9meiiKg5LTfaDk+THDYQYlJLUo2C3tNiuMWcR6YmHKv20V+o0WZ+8Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=mN2Zk5Hk; arc=fail smtp.client-ip=52.101.52.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="mN2Zk5Hk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ShPbiPTihr7IfZIUY508Jo+4fv55NSGToNGb9dYh1CdGQv5TiKLXq4KTQDvI4fyFDyZeiSaVRfOwrYAV2wf6gAFHJulIxv36GPmYyU5aG7zcbByqcQ7Czwo1Q4TuzyXUoSwZSVD/ejZ96yLHAZLLIRCfP5bRKRcqbi8zXR4ne2GtrIJGjLTkFA3sSCZgG/YN1GefhXjMNnVkLv8Iu2tkGvjAda4S6STZhFaVDzwhfZAycQM01MW+7IrytLuexYD2VteOMoRePfElwDOZI2q79xYNHaRL9RIOIvwCA877fNmT58+FcyB8n3QzGKJ7pfAPTDKAjGbk6CUKikPuxyDW5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=84fVI39nJRT7sLAFeI18t2K6d1ZSYalcTjElk+AGlkU=; b=PdBCyzsDeYC40y66zwoag1wsVZx7nfrTXZxtMY+jvyM5z/YCqol9prds/PWG4r8F7U2vqSxelw6iiK9IMVrVthvyEkH1RpZdZJHr1PckRCFZmvwh2peDq/IOLY6xzdUi2xaZWidwLNBGIMIXo/wIfobgy0BUJvStQsM5bvjHl/VAy2gDlXmIZcPjSNFXvVxGsfB75xKvWYPaGP4FvFLiwpRe84skXsa5gU1znXBHjq7x5rHAy+AGI48A+DuH8HqblQYEmyXNnp7DCJ/i8LBikF8uoKapgXVBsx99iCJAza4ikJ3rLWL2qxSw7SDL+kj/InL9e3f7BT6WU41jR6Wfmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84fVI39nJRT7sLAFeI18t2K6d1ZSYalcTjElk+AGlkU=; b=mN2Zk5HkEU/w4lBAe0C/vct8DpS/KryAc74qMO0avL4GlrypbuDXlJufFDdWvSpG0axSRFMabU1/YV1nX6UfDaSuldLXo2ys58+Y3gu2oweugksSo23z55s0kUzi/GT+BwKM1xIVNIQDN0rf7kH4ZfWtMmVbsAEN1ch7KE0NvKxBmZFlnUoHKzp48Ql9++U0XGv2V06SqthKhQ8ok09LO7oVZ2S0Z5pZapmC+/r4NGuOlhCSNf5zVqt5fFscpwfeA19iMmx0lOjrquHN6UNBMuJWTNRZc8rjsxT5STNZ4m9OxZtBpUQ6xqgL7cKHY3DM9izy4TirQAjlcahIDG0DQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20) by SA1PR12MB7269.namprd12.prod.outlook.com (2603:10b6:806:2be::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16; Tue, 3 Mar 2026 05:02:53 +0000 Received: from SJ2PR12MB9161.namprd12.prod.outlook.com ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9654.020; Tue, 3 Mar 2026 05:02:52 +0000 From: Mikko Perttunen To: dri-devel@lists.freedesktop.org, Randy Dunlap Cc: Randy Dunlap , Thierry Reding , linux-tegra@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH] drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings Date: Tue, 03 Mar 2026 14:02:49 +0900 Message-ID: <4366904.irdbgypaU6@senjougahara> In-Reply-To: <20260226215833.989397-1-rdunlap@infradead.org> References: <20260226215833.989397-1-rdunlap@infradead.org> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-ClientProxiedBy: TYCP286CA0014.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:26c::8) To SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20) Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB9161:EE_|SA1PR12MB7269:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d3e0f05-b43c-41bc-d21b-08de78e21fe7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|10070799003; X-Microsoft-Antispam-Message-Info: 44abS3ovJVQs1zNecN7+bvdPPxEl2I6/IkxD+JKrIq+2s6DSEMYq8ezM5LZV5V+YigWDdspTDVgJGD5/pbg973Urbscv6BxU/JwdLiOhXSlh4OxNimkkdo4184qys1N+PpEV9FOTYw86zpDGRaEuedgzhvtT0fxp8Q+mQojly90qajNnrPakWXp7dmonvQppje56HOoJX1nWRLDlrdUELp7F/BriY8JbgiBTxAfOJ6eLTtjawizimMLWEv5rOSK5rGD9e7QS/S1BpIuQBQv5rKhE/wfSrJ4IdwbvoHC46CBGmFwOYElKvBFnE+ZhuOkRCo7wtSHQuYk6B9dyuqt5zGNmP57d+jBuneoEKttEOZOgoDqYfQneCI/OZFg71Oi3GxTPQJhz4RDCxptT5nzRaOJjVg6qVetpeZ+sUXun3MygtZff/rOZFPMsm5YffwxDIRM4UuUF19TXY7mpqTrHFiXWixYC0z2YFdRuCHO0G/48Pw84m6zTr7RdiL7rVLzmS5E8SrFkEjisLHwrC3jvuGFleRsHhEC4d5kV1ybSj81MOSXzfcyBKGxLF9qOoSsM0vceqoTpySiqsFpXzbKjF0rdSphkeoxcC6/twYzzPmro0rhYvDSIWhCwoaLSyf4yEqAdzykdO6SjH3rSWP9c0UWL43EDP74vpdhgIzIMrJKI7B6RBoqV7+XHl/iekjk3JX3MaITU1B3kxZTxx6Ud1Kb0b3uWqrp7SIYkKAas3n0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnNsYWhCd1k4enF6Mmk3WUtId3hsOGlWbHUxWEppY3VsSXZwdjFWejc1ajFC?= =?utf-8?B?eUw4Z2pJdHNuVUpTb3E4ZWEzaHJxcHoxWjdkL3NkMmpVMkVmQUhNVE94QTdU?= =?utf-8?B?N2ZKTGp1dkVlek41Q0xSbEpwcHpuMTU4YWU5cjZkY2lXZTFRc2p5ZHhIaGRG?= =?utf-8?B?TEtLem9vL3FldzlzcmtwOVBYVUFIc1c3ZURKc0EraDNlcmxnOHhhNFlLbmVx?= =?utf-8?B?YUNTc2djb0ExYW9lSFprcURPSWtINVpyMnBSVERhV3lMeDdxcFBZZDh0N1c1?= =?utf-8?B?NStVLytkRnMwL3RydG5oTWJJUHVSeCtHaUtxMDBQR2dIc09mN2JjVXNoSlFv?= =?utf-8?B?T2NzV0lUcS9UNzRkWmN3VTJLR1BRZ1dDeU02Uitqc0hndzVjcElEV0R0YWx3?= =?utf-8?B?TmVMajZZdVNMenBVNWIzWlI0NTNkdWJNeUNoUzh4UjZhOXNVZVlwa2RTRGdm?= =?utf-8?B?bm82L05HK1ZXS05QdnFVRm1kL3lHREgwT092dlY4ZnUvWXZDRmZEM1VHWkUv?= =?utf-8?B?cmVZNERNZFI3NlMwYkdra0xuQjAvN0VGamx5Mi82YWtYUmN2TFdkVGgzY3dT?= =?utf-8?B?QkJGb2g5UGMwcWEyUFFKak9FZWI4R0NLaUM3UmdJS0VBaHVVUlhoVXNaRGM0?= =?utf-8?B?NlNyMCtWRDJJd0FBaVVrdEk1WHpZdmdpd1BISEtQeE43Sno2K2t1WkNGUGxM?= =?utf-8?B?NnhkQk5mYXNWUkxtUGQzUk9iU2Z4NGg0UUFrV1RlYmtBeDFGTmhwWW5ZV05z?= =?utf-8?B?S0pIa0lKS1l5OXJGaURraTNjU3MzWEdtY2gyY2FMb0c4ckI3UjZhTS9xTTdl?= =?utf-8?B?U3VqWkxuYnIyaytWa1B6REowdWE0aHBDSFkwSERYaWVNdkkxeG54TEdKZFcr?= =?utf-8?B?ZUNIVEtEOVhHMWtNbEM4cmlBMnpwMUNiODAxaVZ6VGVSZzF5cG1FRnM0YTcz?= =?utf-8?B?Q3VlQjFMTTJ1L3ZGSHBpanlucU1IREVycC9pdEpybGRybWw1SHVnNGk5NGpm?= =?utf-8?B?RDQyemFrN3FZeWNzR0xKYTlKck1ZcEQ2KzdlQ3ViMVU4NGwzTVN5OE1Ra3dj?= =?utf-8?B?NkZsR1hucUJudzhDenQrRVVSRkt5NWtDaWhwVm9PREtTL0VFb3JwZHM5UU9J?= =?utf-8?B?aktzVysvUFlEMmZtSlQyVGZhTFRIWWVZNDdlOFhWcHZYOTRUUnhiNHFzK2da?= =?utf-8?B?Y1pSYVMzWUl3U0QzR0FWUTVxN2c3Z0NqSkdmdEVLRUgyT2ZjL0NGbmRoTFV4?= =?utf-8?B?elZ0bjlxU3NPYi94YStEQ3NNcS8ycWZQM3JUTkhkdzNIVFVoSnM5Q1c0cmtU?= =?utf-8?B?Z2t0SGtNZlp2WTdYMG5NN3UyeVk4YW5tcUxDREJQWFZxS0VraFFRM21VWTRs?= =?utf-8?B?TGhTYTlRSkh4Zk9VSjFDY1FXT3RxZDRBUTRGU09HTlRvZHhQNGRVbjVhQVd6?= =?utf-8?B?QmRQdERZL1BKRm0xeG1KS1FDYTRhZVl5TWdraDVJaGJWejhBd3NqbStUbytL?= =?utf-8?B?UFRBcTYyWnk1UzNkS3lCNU4vcWs5K2NZdG1FR01CaURrZUY2OHVzRnRXc2J3?= =?utf-8?B?UkNRL0gyTno4MUFCaGh4TWwzVUhWc1pxMjFWMHROWG9aRmJCY1RTSWs0NU9z?= =?utf-8?B?bnZHWG54L0ZZc1ZkUzNRNTBvQjNRUVhjaVdwQ1Z3SHNOR296ZWUxUEw0TUxN?= =?utf-8?B?SWR3QmJkZzdXQ1ZHUmN1T09wZDNCTnNZS0FOQmVxZ1JqYzBuQ2l6aUZlUndI?= =?utf-8?B?UzFTckIzaDBIY2FzdjloVGw5YncyY2diKzRlSG92bkROeEk0Sm5sYTlFUmRn?= =?utf-8?B?T1VNZDMyRE4renAvRElUNGpXREVzdXhscWRNYmxndzRab05uZGVlRngzbnhS?= =?utf-8?B?b2ErenRvSmY5SnIzMS9wdW52T1V0b3AxSEZhTHJUcGJ6Q1g5TDhYbDU0Tk9m?= =?utf-8?B?MVBjVS9IOTI2OGUydFQzS0UzdUV4Zm5zZzN6ZXo2eDUxT01ITE5nRmhXT2xx?= =?utf-8?B?eU9DN0lmKysxWERpY1lDa0xrazMxWVdVV08rWi8vczNCY0lMTitrWm12bGNU?= =?utf-8?B?V3VGR0J2bytwaTYxZFlraFpBdWhvUkVtbExSLzJJTi81MjMwN0pPOTlESkxl?= =?utf-8?B?bUNzYkQybTBaL1BVY3pvMTdnTmNrSFdHV1NicFMrZy90d3ExSW1EZm1vUVVX?= =?utf-8?B?cnJOOENWclNjMVZ0MWNMYitGR3lveVNhWDN0N09SdXloTVVqQUE5cHRPRS9X?= =?utf-8?B?dCtCWlg1SERPN3ByRmFvUkN5UVpXL0ZjdGpIbEIzOG1xSDllVnFOR3QyWHlk?= =?utf-8?B?L0tSelVTMTJZMVpQR1VSbW1zQ2txWm15alFrNXQ2Kzc4dGpSSSt1eTdGQnBh?= =?utf-8?Q?f2foUfZs7dexvCiZNTJmoASeVqs1vSuRypC8OvmSbDpAY?= X-MS-Exchange-AntiSpam-MessageData-1: gALXVK7w11K9IQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d3e0f05-b43c-41bc-d21b-08de78e21fe7 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB9161.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 05:02:52.8688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hMl1K5r19YAkjybWmsYuda8f3w/dC4y02dBIQq4bImIXafJgelrreCCtK2tlAUkybFiaafvu+t3YUsImBhHy+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7269 On Friday, February 27, 2026 6:58=E2=80=AFAM Randy Dunlap wrote: > Add 2 struct member descriptions and demote several comments from > "/**" kernel-doc comments to plain C "/*" comments to eliminate all > kernel-doc warnings: >=20 > Warning: include/uapi/drm/tegra_drm.h:353 struct member 'cmdbuf' not > described in 'drm_tegra_reloc' > Warning: include/uapi/drm/tegra_drm.h:353 struct member 'target' not > described in 'drm_tegra_reloc' >=20 > Warning: include/uapi/drm/tegra_drm.h:780 This comment starts with '/**', > but isn't a kernel-doc comment. > * Specify that bit 39 of the patched-in address should be set to switch > Warning: include/uapi/drm/tegra_drm.h:832 This comment starts with '/**', > but isn't a kernel-doc comment. > * Execute `words` words of Host1x opcodes specified in the > `gather_data_ptr` > Warning: include/uapi/drm/tegra_drm.h:837 This comment starts with '/**', > but isn't a kernel-doc comment. > * Wait for a syncpoint to reach a value before continuing with further > Warning: include/uapi/drm/tegra_drm.h:842 This comment starts with '/**', > but isn't a kernel-doc comment. > * Wait for a syncpoint to reach a value before continuing with further >=20 > Signed-off-by: Randy Dunlap > --- > Cc: Thierry Reding > Cc: Mikko Perttunen > Cc: linux-tegra@vger.kernel.org > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Simona Vetter >=20 > include/uapi/drm/tegra_drm.h | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > --- linux-next-20260226.orig/include/uapi/drm/tegra_drm.h > +++ linux-next-20260226/include/uapi/drm/tegra_drm.h > @@ -304,6 +304,7 @@ struct drm_tegra_cmdbuf { > * struct drm_tegra_reloc - GEM object relocation structure > */ > struct drm_tegra_reloc { > + /** @cmdbuf: cmd information */ > struct { > /** > * @cmdbuf.handle: > @@ -321,6 +322,7 @@ struct drm_tegra_reloc { > */ > __u32 offset; > } cmdbuf; > + /** @target: relocate target information */ > struct { > /** > * @target.handle: > @@ -777,7 +779,7 @@ struct drm_tegra_channel_unmap { >=20 > /* Submission */ >=20 > -/** > +/* Looks like kerneldoc has syntax for documenting defines, so it would be bet= ter=20 to change these to use that rather than demoting to standard comments, I=20 think. For example, /** * define DRM_TEGRA_SUBMIT_RELOC_SECTOR_LAYOUT - \ * Select sector layout swizzling for in-memory buffers. * * Specify that bit 39 of the patched-in address should be set to switch * swizzling between Tegra and non-Tegra sector layout on systems that stor= e * surfaces in system memory in non-Tegra sector layout. */ /** * define DRM_TEGRA_SUBMIT_CMD_GATHER_UPTR - \ * Execute Host1x opcodes from user pointer. * * Execute `words` words of Host1x opcodes specified in the `gather_data_pt= r` * buffer. Each GATHER_UPTR command uses successive words from the buffer. */ /** * define DRM_TEGRA_SUBMIT_CMD_WAIT_SYNCPT - \ * Wait for syncpoint (absolute). * * Wait for a syncpoint to reach a value before continuing with further * commands. */ /** * define DRM_TEGRA_SUBMIT_CMD_WAIT_SYNCPT_RELATIVE - \ * Wait for syncpoint (relative). * * Wait for a syncpoint to reach a value before continuing with further * commands. The threshold is calculated relative to the start of the job. */ Otherwise, looks good to me. Thank you, Mikko > * Specify that bit 39 of the patched-in address should be set to switch > * swizzling between Tegra and non-Tegra sector layout on systems that > store * surfaces in system memory in non-Tegra sector layout. > @@ -829,17 +831,17 @@ struct drm_tegra_submit_buf { > } reloc; > }; >=20 > -/** > +/* > * Execute `words` words of Host1x opcodes specified in the > `gather_data_ptr` * buffer. Each GATHER_UPTR command uses successive word= s > from the buffer. */ > #define DRM_TEGRA_SUBMIT_CMD_GATHER_UPTR 0 > -/** > +/* > * Wait for a syncpoint to reach a value before continuing with further > * commands. > */ > #define DRM_TEGRA_SUBMIT_CMD_WAIT_SYNCPT 1 > -/** > +/* > * Wait for a syncpoint to reach a value before continuing with further > * commands. The threshold is calculated relative to the start of the jo= b. > */