From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Dietrich Subject: Re: [PATCH 3/5] ARM: dt: tegra: add ADT7461 temperature sensortopaz00 device tree Date: Tue, 31 Jan 2012 19:55:38 +0100 Message-ID: <4429293.NIOF4BJ2Er@ax5200p> References: <4539920.1hFmNlShaA@fb07-iapwap2> <74CDBE0F657A3D45AFBB94109FB122FF178E124426@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF178E124426-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Colin Cross , Olof Johansson List-Id: linux-tegra@vger.kernel.org Hi Stephen, On Tuesday 31 January 2012 09:27:17 Stephen Warren wrote: > Marc Dietrich wrote at Tuesday, January 31, 2012 4:49 AM: > > Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren: > > > Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM: > > > > Add the ADT7461 temperature monitoring IC which is connected via > > > > the DVC controller. > > > > > > > > diff --git a/arch/arm/boot/dts/tegra-paz00.dts > > > > b/arch/arm/boot/dts/tegra-paz00.dts > > > > > > > > + adt7461@4c { > > > > + compatible = "adt7461"; > > > > > > Compatible should have a vendor prefix, so "adi,adt7461". > > > > you are right, that's the problem when just copy-n-paste from seaboard. > > On the other hand, I wonder why this worked at all, because lm90 does > > not contain an of_match_table yet. Is there also some "hidden" > > DT->platfrom_data conversion? > I2C drivers can bind in two ways: > > 1) Direct use of an of_match_table. > > 2) Use of the i2c_device_id table. In this case, the I2C or OF core strips > the vendor prefix (if any) from the compatible value, and checks it > against all the entries in i2c_driver.id_table. > > The latter is how your patch worked. ah, thanks for the explanation. Marc