From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>, James Jones <jajones@nvidia.com>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later
Date: Tue, 23 Mar 2021 20:57:42 +0300 [thread overview]
Message-ID: <454aea05-ee94-5789-2cab-513342cf7614@gmail.com> (raw)
In-Reply-To: <20210323155437.513497-5-thierry.reding@gmail.com>
23.03.2021 18:54, Thierry Reding пишет:
> @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct drm_plane *plane,
> value = tegra_dc_readl(dc, DC_DISP_BLEND_CURSOR_CONTROL);
> value &= ~CURSOR_DST_BLEND_MASK;
> value &= ~CURSOR_SRC_BLEND_MASK;
> - value |= CURSOR_MODE_NORMAL;
> +
> + if (dc->soc->has_nvdisplay)
> + value &= ~CURSOR_COMPOSITION_MODE_XOR;
> + else
> + value |= CURSOR_MODE_NORMAL;
> +
> value |= CURSOR_DST_BLEND_NEG_K1_TIMES_SRC;
> value |= CURSOR_SRC_BLEND_K1_TIMES_SRC;
> value |= CURSOR_ALPHA;
> tegra_dc_writel(dc, value, DC_DISP_BLEND_CURSOR_CONTROL);
>
> + /* nvdisplay relies on software for clipping */
> + if (dc->soc->has_nvdisplay) {
But coordinates already should be clipped by
drm_atomic_helper_check_plane_state().
next prev parent reply other threads:[~2021-03-23 17:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 15:54 [PATCH 0/9] drm/tegra: Various improvements Thierry Reding
2021-03-23 15:54 ` [PATCH 1/9] drm/fourcc: Add macro to check for the modifier vendor Thierry Reding
2021-03-23 16:04 ` Simon Ser
2021-03-23 16:49 ` Thierry Reding
2021-03-23 15:54 ` [PATCH 2/9] drm/tegra: dc: Inherit DMA mask Thierry Reding
2021-03-23 15:54 ` [PATCH 3/9] drm/tegra: dc: Parameterize maximum resolution Thierry Reding
2021-03-23 15:54 ` [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later Thierry Reding
2021-03-23 17:57 ` Dmitry Osipenko [this message]
2021-03-23 18:24 ` Thierry Reding
2021-03-23 19:05 ` Dmitry Osipenko
2021-03-24 15:03 ` Thierry Reding
2021-03-23 15:54 ` [PATCH 5/9] drm/tegra: fb: Add diagnostics for framebuffer modifiers Thierry Reding
2021-03-23 15:54 ` [PATCH 6/9] drm/tegra: gem: Add a clarifying comment Thierry Reding
2021-03-24 14:41 ` Dmitry Osipenko
2021-03-24 15:02 ` Thierry Reding
2021-03-24 15:45 ` Dmitry Osipenko
2021-03-24 16:42 ` Thierry Reding
2021-03-24 16:50 ` Dmitry Osipenko
2021-03-26 16:37 ` Thierry Reding
2021-03-28 14:29 ` Dmitry Osipenko
2021-03-23 15:54 ` [PATCH 7/9] gpu: host1x: Add early init and late exit callbacks Thierry Reding
2021-03-23 15:54 ` [PATCH 8/9] drm/tegra: Count number of display controllers at runtime Thierry Reding
2021-03-23 15:54 ` [PATCH 9/9] drm/tegra: Support sector layout on Tegra194 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454aea05-ee94-5789-2cab-513342cf7614@gmail.com \
--to=digetx@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jajones@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox