From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"raphael.gallais-pou@foss.st.com"
<raphael.gallais-pou@foss.st.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"andy.yan@rock-chips.com" <andy.yan@rock-chips.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
"heiko@sntech.de" <heiko@sntech.de>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"asrivats@redhat.com" <asrivats@redhat.com>,
"philippe.cornu@foss.st.com" <philippe.cornu@foss.st.com>,
"stefan@agner.ch" <stefan@agner.ch>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"abrodkin@synopsys.com" <abrodkin@synopsys.com>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"kernel-list@raspberrypi.com" <kernel-list@raspberrypi.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"mcanal@igalia.com" <mcanal@igalia.com>,
"tiantao6@hisilicon.com" <tiantao6@hisilicon.com>,
"jstultz@google.com" <jstultz@google.com>,
"mperttunen@nvidia.com" <mperttunen@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"yannick.fertre@foss.st.com" <yannick.fertre@foss.st.com>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"airlied@gmail.com" <airlied@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"alison.wang@nxp.com" <alison.wang@nxp.com>,
"marex@denx.de" <marex@denx.de>,
"xinliang.liu@linaro.org" <xinliang.liu@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"rgallaispou@gmail.com" <rgallaispou@gmail.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"dave.stevenson@raspberrypi.com" <dave.stevenson@raspberrypi.com>,
"yongqin.liu@linaro.org" <yongqin.liu@linaro.org>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"alain.volmat@foss.st.com" <alain.volmat@foss.st.com>,
"hjc@rock-chips.com" <hjc@rock-chips.com>,
"tzimmermann@suse.de" <tzimmermann@suse.de>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 04/12] drm/mediatek: move to devm_platform_ioremap_resource() usage
Date: Fri, 7 Feb 2025 02:15:07 +0000 [thread overview]
Message-ID: <456d92e10e8fd8d58cd524878902790fbc789850.camel@mediatek.com> (raw)
In-Reply-To: <20250205-mem-cocci-newapi-v1-4-aebf2b0e2300@redhat.com>
Hi, Anusha:
On Wed, 2025-02-05 at 15:08 -0500, Anusha Srivatsa wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Replace platform_get_resource + devm_ioremap_resource
> with just devm_platform_ioremap_resource()
>
> Used Coccinelle to do this change. SmPl patch:
> @rule_1@
> identifier res;
> expression ioremap_res;
> identifier pdev;
> @@
> -struct resource *res;
> ...
> -res = platform_get_resource(pdev,...);
> -ioremap_res = devm_ioremap_resource(...);
> +ioremap_res = devm_platform_ioremap_resource(pdev,0);
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_color.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 4 +---
> 8 files changed, 8 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c
> index dd8433a38282a9ba1bcc3a4ddd01dd89738ccb60..39c7de4cdcc16b56a5a1d046aaabaf5580227ed2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_color.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_color.c
> @@ -96,7 +96,6 @@ static int mtk_disp_color_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_color *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -108,8 +107,7 @@ static int mtk_disp_color_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get color clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap color\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
> index b17b11d93846f2019d8c4afb294375333e22dc42..8afd15006df2a21f3f52fe00eca3c5501f4fb76a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
> @@ -256,7 +256,6 @@ static int mtk_disp_gamma_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_gamma *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -268,8 +267,7 @@ static int mtk_disp_gamma_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get gamma clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap gamma\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_merge.c b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
> index 563b1b248fbbb38ef03bb3e3ceecdd265961df60..b174dda091d3fbd16796e8e128b030fccf5b902c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_merge.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
> @@ -306,7 +306,6 @@ static const struct component_ops mtk_disp_merge_component_ops = {
> static int mtk_disp_merge_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *res;
> struct mtk_disp_merge *priv;
> int ret;
>
> @@ -314,8 +313,7 @@ static int mtk_disp_merge_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap merge\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index df82cea4bb79c472acbb66e0df27fbad3e70bd20..d0581c4e3c999cf865fdd0aaf4c2f38dd404926e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -604,7 +604,6 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_ovl *priv;
> - struct resource *res;
> int irq;
> int ret;
>
> @@ -621,8 +620,7 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get ovl clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap ovl\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> index bf47790e4d6be5d60070c63c15c75fa201cc4b27..c9d41d75e7f2a3af5820921b7e563da377ce8d0d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> @@ -313,7 +313,6 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_rdma *priv;
> - struct resource *res;
> int irq;
> int ret;
>
> @@ -330,8 +329,7 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get rdma clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap rdma\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 40752f2320548fbf6c7de96b18e8a636ac9c31be..f298293471de49473dd05973383dc22f7d3b6c23 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1192,7 +1192,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> {
> struct mtk_dsi *dsi;
> struct device *dev = &pdev->dev;
> - struct resource *regs;
> int irq_num;
> int ret;
>
> @@ -1217,8 +1216,7 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> if (IS_ERR(dsi->hs_clk))
> return dev_err_probe(dev, PTR_ERR(dsi->hs_clk), "Failed to get hs clock\n");
>
> - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dsi->regs = devm_ioremap_resource(dev, regs);
> + dsi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dsi->regs))
> return dev_err_probe(dev, PTR_ERR(dsi->regs), "Failed to ioremap memory\n");
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index ca82bc829cb96446d4d34eeef45848df03bd716b..d729c13590cb5ec176f15b680c262a26b677e6aa 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1425,7 +1425,6 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,
> struct device_node *cec_np, *remote, *i2c_np;
> struct platform_device *cec_pdev;
> struct regmap *regmap;
> - struct resource *mem;
> int ret;
>
> ret = mtk_hdmi_get_all_clk(hdmi, np);
> @@ -1471,8 +1470,7 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,
> }
> hdmi->sys_regmap = regmap;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - hdmi->regs = devm_ioremap_resource(dev, mem);
> + hdmi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(hdmi->regs)) {
> ret = PTR_ERR(hdmi->regs);
> goto put_device;
> diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> index fc69ee38ce7d6a245a7460cfde8de426e83b2e80..7982788ae9df51f1a378d8d538737f38af7299f2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> @@ -291,7 +291,6 @@ static const struct component_ops mtk_mdp_rdma_component_ops = {
> static int mtk_mdp_rdma_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *res;
> struct mtk_mdp_rdma *priv;
> int ret = 0;
>
> @@ -299,8 +298,7 @@ static int mtk_mdp_rdma_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap rdma\n");
>
> --
> 2.47.0
>
>
next prev parent reply other threads:[~2025-02-07 2:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 20:07 [PATCH 00/12] drm: Move to using devm_platform_ioremap_resource Anusha Srivatsa
2025-02-05 20:07 ` [PATCH 01/12] drm/aspeed: move to devm_platform_ioremap_resource() usage Anusha Srivatsa
2025-02-05 20:07 ` [PATCH 02/12] drm/fsl-dcu: " Anusha Srivatsa
2025-02-05 20:07 ` [PATCH 03/12] drm/hisilicon: " Anusha Srivatsa
2025-02-05 20:08 ` [PATCH 04/12] drm/mediatek: " Anusha Srivatsa
2025-02-06 14:15 ` Maxime Ripard
2025-02-07 2:15 ` CK Hu (胡俊光) [this message]
2025-02-05 20:08 ` [PATCH 05/12] drm/mxsfb: " Anusha Srivatsa
2025-02-05 20:08 ` [PATCH 06/12] drm/sprd: " Anusha Srivatsa
2025-02-06 14:15 ` Maxime Ripard
2025-02-05 20:08 ` [PATCH 07/12] drm/sti: " Anusha Srivatsa
2025-02-06 14:16 ` Maxime Ripard
2025-02-11 17:45 ` Raphaël Gallais-Pou
2025-02-05 20:08 ` [PATCH 08/12] drm/stm: " Anusha Srivatsa
2025-02-05 20:08 ` [PATCH 09/12] drm/tegra: " Anusha Srivatsa
2025-02-05 20:08 ` [PATCH 10/12] drm/tiny: " Anusha Srivatsa
2025-02-05 20:08 ` [PATCH 11/12] drm/vc4: " Anusha Srivatsa
2025-02-06 16:13 ` Maxime Ripard
[not found] ` <CAN9Xe3SpTG7r2UkN7_pH0uMXhU5u+dkWhaM9+w5VyOQZp9byNg@mail.gmail.com>
2025-02-14 9:44 ` Maxime Ripard
2025-02-05 20:08 ` [PATCH 12/12] Documentation: Update the todo Anusha Srivatsa
2025-02-06 7:57 ` Thomas Zimmermann
-- strict thread matches above, loose matches on Subject: below --
2025-02-14 0:19 [PATCH 00/12] drm: Move to using devm_platform_ioremap_resource Anusha Srivatsa
2025-02-14 0:19 ` [PATCH 04/12] drm/mediatek: move to devm_platform_ioremap_resource() usage Anusha Srivatsa
2025-03-02 15:04 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456d92e10e8fd8d58cd524878902790fbc789850.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alison.wang@nxp.com \
--cc=andrew@codeconstruct.com.au \
--cc=andy.yan@rock-chips.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asrivats@redhat.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=chunkuang.hu@kernel.org \
--cc=corbet@lwn.net \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=imx@lists.linux.dev \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=jstultz@google.com \
--cc=kernel-list@raspberrypi.com \
--cc=kernel@pengutronix.de \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=matthias.bgg@gmail.com \
--cc=mcanal@igalia.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mperttunen@nvidia.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=philippe.cornu@foss.st.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=rgallaispou@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=stefan@agner.ch \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
--cc=yannick.fertre@foss.st.com \
--cc=yongqin.liu@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox