From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH V3] serial: 8250_tegra: Create Tegra specific 8250 driver Date: Wed, 29 Jan 2020 22:04:01 +0300 Message-ID: <45ac5b66-e09a-e328-6ebf-3fbbe97b7873@gmail.com> References: <20200129132817.26343-1-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200129132817.26343-1-jonathanh@nvidia.com> Content-Language: en-US Sender: linux-serial-owner@vger.kernel.org To: Jon Hunter , Greg Kroah-Hartman , Jiri Slaby , Thierry Reding Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Jeff Brasen List-Id: linux-tegra@vger.kernel.org 29.01.2020 16:28, Jon Hunter пишет: ... > +#ifdef CONFIG_PM_SLEEP > +static int tegra_uart_suspend(struct device *dev) > +{ Nit: the ifdef'ing in the code could be avoided by using the __maybe_unused attribute.