From: Adrian Hunter <adrian.hunter@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jon Hunter <jonathanh@nvidia.com>, Jens Axboe <axboe@kernel.dk>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 17/17] mmc: pass queue_limits to blk_mq_alloc_disk
Date: Fri, 28 Jun 2024 15:37:35 +0300 [thread overview]
Message-ID: <48066c53-e421-46a5-a3dd-ecb7a024dff9@intel.com> (raw)
In-Reply-To: <20240628123214.GB17080@lst.de>
On 28/06/24 15:32, Christoph Hellwig wrote:
> On Fri, Jun 28, 2024 at 11:06:54AM +0300, Adrian Hunter wrote:
>> On 27/06/24 17:47, Christoph Hellwig wrote:
>>> On Thu, Jun 27, 2024 at 04:44:30PM +0300, Adrian Hunter wrote:
>>>> Probably just do what the block layer was doing e.g.
>>>
>>> That was really just a hack due to the lack of error handling in
>>> the old blk_queue_* interfaces. If ADMA really doesn't actually have
>>> a limitation, please just don't set any max_segment_size at all.
>>>
>>
>> There is a limitation of 64KiB max. (or less with
>> SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC) per descriptor.
>
> Hmm, I thought the conflusion was that it can be more, which is why
> you proposed to increase it if the PAGE_SIZE is >= 64k. And based on
> Jon's report at least for his tegra setups it works with 64k.
There is a workaround in that case to split to 32KiB chunks
next prev parent reply other threads:[~2024-06-28 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240215070300.2200308-1-hch@lst.de>
[not found] ` <20240215070300.2200308-18-hch@lst.de>
2024-06-27 9:43 ` [PATCH 17/17] mmc: pass queue_limits to blk_mq_alloc_disk Jon Hunter
2024-06-27 9:49 ` Christoph Hellwig
2024-06-27 9:58 ` Jon Hunter
2024-06-27 11:19 ` Christoph Hellwig
2024-06-27 12:30 ` Jon Hunter
2024-06-27 12:44 ` Christoph Hellwig
2024-06-27 13:09 ` Jon Hunter
2024-06-27 13:44 ` Adrian Hunter
2024-06-27 14:47 ` Christoph Hellwig
2024-06-28 8:06 ` Adrian Hunter
2024-06-28 12:32 ` Christoph Hellwig
2024-06-28 12:37 ` Adrian Hunter [this message]
2024-06-28 12:51 ` Christoph Hellwig
2024-06-28 13:45 ` Adrian Hunter
2024-07-03 8:22 ` Jon Hunter
2024-07-04 7:24 ` Christoph Hellwig
2024-06-28 9:05 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48066c53-e421-46a5-a3dd-ecb7a024dff9@intel.com \
--to=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).