Re: [PATCH] bus: tegra-aconnect: Use dev_err_probe for probe error paths

[Jon Hunter <jonathanh@nvidia.com>]

On 18/03/2026 07:11, Sheetal wrote:
> Convert probe error handling to use dev_err_probe() which provides
> proper handling of -EPROBE_DEFER.
> 
> Signed-off-by: Sheetal <sheetal@nvidia.com>
> ---
>   drivers/bus/tegra-aconnect.c | 14 ++++++--------
>   1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/bus/tegra-aconnect.c b/drivers/bus/tegra-aconnect.c
> index 90e3b0a10816..9b2b227332b2 100644
> --- a/drivers/bus/tegra-aconnect.c
> +++ b/drivers/bus/tegra-aconnect.c
> @@ -32,16 +32,14 @@ static int tegra_aconnect_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	aconnect->ape_clk = devm_clk_get(&pdev->dev, "ape");
> -	if (IS_ERR(aconnect->ape_clk)) {
> -		dev_err(&pdev->dev, "Can't retrieve ape clock\n");
> -		return PTR_ERR(aconnect->ape_clk);
> -	}
> +	if (IS_ERR(aconnect->ape_clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(aconnect->ape_clk),
> +				     "can't retrieve ape clock\n");
>   
>   	aconnect->apb2ape_clk = devm_clk_get(&pdev->dev, "apb2ape");
> -	if (IS_ERR(aconnect->apb2ape_clk)) {
> -		dev_err(&pdev->dev, "Can't retrieve apb2ape clock\n");
> -		return PTR_ERR(aconnect->apb2ape_clk);
> -	}
> +	if (IS_ERR(aconnect->apb2ape_clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(aconnect->apb2ape_clk),
> +				     "can't retrieve apb2ape clock\n");
>   
>   	dev_set_drvdata(&pdev->dev, aconnect);
>   	pm_runtime_enable(&pdev->dev);


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic