Re: [PATCH RESEND] drm/tegra: dp: fix kernel-doc warnings in dp.h

[Mikko Perttunen <mperttunen@nvidia.com>]

On Friday, February 20, 2026 6:55 AM Randy Dunlap wrote:
> Use correct kernel-doc format and add missing nested struct entries to
> eliminate kernel-doc warnings:
> 
> Warning: drivers/gpu/drm/tegra/dp.h:28 Incorrect use of kernel-doc
> format: * tps3_supported:
> Warning: drivers/gpu/drm/tegra/dp.h:54 struct member 'tps3_supported'
>  not described in 'drm_dp_link_caps'
> dp.h:73: warning: Function parameter or struct member 'apply_training'
> not described in 'drm_dp_link_ops'
> dp.h:73: warning: Function parameter or struct member 'configure'
>  not described in 'drm_dp_link_ops'
> dp.h:160: warning: Excess struct member 'cr' description in
> 'drm_dp_link'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: linux-tegra@vger.kernel.org
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Simona Vetter <simona@ffwll.ch>
> ---
>  drivers/gpu/drm/tegra/dp.h |   12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> --- linux-next-20260218.orig/drivers/gpu/drm/tegra/dp.h
> +++ linux-next-20260218/drivers/gpu/drm/tegra/dp.h
> @@ -26,7 +26,7 @@ struct drm_dp_link_caps {
>  	bool enhanced_framing;
> 
>  	/**
> -	 * tps3_supported:
> +	 * @tps3_supported:
>  	 *
>  	 * training pattern sequence 3 supported for equalization
>  	 */
> @@ -62,12 +62,12 @@ void drm_dp_link_caps_copy(struct drm_dp
>   */
>  struct drm_dp_link_ops {
>  	/**
> -	 * @apply_training:
> +	 * @apply_training: apply the link training
>  	 */
>  	int (*apply_training)(struct drm_dp_link *link);
> 
>  	/**
> -	 * @configure:
> +	 * @configure: configure the DP link
>  	 */
>  	int (*configure)(struct drm_dp_link *link);
>  };
> @@ -113,6 +113,8 @@ struct drm_dp_link_train {
>   * @max_lanes: maximum number of lanes supported on the link
>   * @caps: capabilities supported on the link (see &drm_dp_link_caps)
>   * @aux_rd_interval: AUX read interval to use for training (in
> microseconds) + * @aux_rd_interval.cr: clock recovery read interval
> + * @aux_rd_interval.ce: channel equalization read interval
>   * @edp: eDP revision (0x11: eDP 1.1, 0x12: eDP 1.2, ...)
>   * @rate: currently configured link rate
>   * @lanes: currently configured number of lanes
> @@ -126,10 +128,6 @@ struct drm_dp_link {
> 
>  	struct drm_dp_link_caps caps;
> 
> -	/**
> -	 * @cr: clock recovery read interval
> -	 * @ce: channel equalization read interval
> -	 */
>  	struct {
>  		unsigned int cr;
>  		unsigned int ce;

Acked-by: Mikko Perttunen <mperttunen@nvidia.com>