From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Subject: Re: [PATCH v4 1/4] usb: otg: Add ulpi viewport access ops Date: Tue, 22 Feb 2011 16:42:59 +0200 Message-ID: <4D63CB73.8040506@compulab.co.il> References: <1298000565-20627-1-git-send-email-benoit@android.com> <1298000565-20627-2-git-send-email-benoit@android.com> <4D5E9337.3010603@compulab.co.il> <4D622A97.2040101@parrot.com> <4D62593C.4070000@compulab.co.il> <4D628501.50105@parrot.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <4D628501.50105-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matthieu CASTET Cc: Benoit Goby , David Brownell , Greg Kroah-Hartman , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Robert Morell , Olof Johansson , Erik Gilling , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org Hi, On 02/21/11 17:30, Matthieu CASTET wrote: > Igor Grinberg a =E9crit : >> Hi, >> >> On 02/21/11 11:04, Matthieu CASTET wrote: >> >>> Hi, >>> >>> Igor Grinberg a =E9crit : >>>> Hi, >>>> >>>> On 02/18/11 05:42, Benoit Goby wrote: >>>>> Add generic access ops for controllers with a ulpi viewport regis= ter >>>>> (e.g. Chipidea/ARC based controllers). >>>> I can see mxc, msm and langwell are using the same bits >>>> (or at least some of them). >>> They all use the Chipidea/ARC usb controllers. >> >> This means, that it is not generic, but Chipidea/ARC usb controller = specific. >> And it is common to some/many platforms. > Yes >> >> Can it be utilized on platforms that have another kind of ulpi acces= s register? > I don't think so I've looked into the IMX Reference Manual regarding the ulpi viewport r= egister and it looks like these access ops can be utilized on another kind of u= lpi access registers, as the same features are available in most (if not all) of ulpi access = registers, whether they are called viewport or otherwise. This will require much more thinking and may be the right solution woul= d be multiple access ops files (e.g. drivers/usb/otg/ulpi_...port.c). So for now, this patch is a good stuff to start from. Benoit, can you, please, address comments in my first reply? Thanks. > >> >>>> Is there some kind of specification for this ulpi viewport registe= r? >>> You can find the Chipidea/ARC datasheet in IMX35 datasheet ( got 0= x0170 ULPI VIEWPORT) or a newer version (extra fields in some register= s but miss 0x168-0x170) in >>> http://www.nxp.com/documents/user_manual/UM10314.pdf >> >> I don't have the IMX35 datasheet which describes the USB OTG registe= rs. >> The one that can be downloaded from Freescale website, only describe= s >> hardware and no ULPI viewport is mentioned there. > From freescale.com I manage to download IMX35RM.pdf witch describe it= (p2075). =46ound it. Thanks. --=20 Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" = in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html