From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC Date: Wed, 09 Mar 2011 13:53:38 +0200 Message-ID: <4D776A42.9030107@compulab.co.il> References: <4ade6d195fff78271085eafb0a99de3be8beb426.1299588456.git.mike@compulab.co.il> <20110308131541.GB5892@sirena.org.uk> <4D772F23.70304@compulab.co.il> <20110309101508.GD6923@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110309101508.GD6923-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Erik Gilling , Colin Cross List-Id: linux-tegra@vger.kernel.org On 03/09/11 12:15, Mark Brown wrote: > On Wed, Mar 09, 2011 at 09:41:23AM +0200, Mike Rapoport wrote: >> On 03/08/11 15:15, Mark Brown wrote: > >>> I feel sure that some of these could be using a struct device, though >>> since they're probably all going to be required to be always on I'd >>> expect it's not useful to have them mapped as supplies at all and the >>> drivers could just assume they were there. > >> I'd prefer to keep it as is for now and update the supplies when merging the >> drivers that actually use them. > > There's no point in keepig them if they don't match up with the actual > drivers and having this sort of stuff in the kernel means it might get > picked up as reference code by other users. If you want to label the > supplies to match the rails on the board the name field in constraints > is intended for that purpose. As for me, I'd be fine with registering only the pex_clk supply and ldo0 to allow PCI-e on Harmony :) If Tegra folks are Ok with it, I'd drop the rest and we'll add more regulators and supplies together with drivers that use them. -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html