From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC Date: Wed, 09 Mar 2011 15:19:40 +0200 Message-ID: <4D777E6C.5040000@compulab.co.il> References: <4ade6d195fff78271085eafb0a99de3be8beb426.1299588456.git.mike@compulab.co.il> <20110308131541.GB5892@sirena.org.uk> <4D772F23.70304@compulab.co.il> <20110309101508.GD6923@opensource.wolfsonmicro.com> <4D776A42.9030107@compulab.co.il> <20110309122222.GG6923@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110309122222.GG6923-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Erik Gilling , Colin Cross List-Id: linux-tegra@vger.kernel.org On 03/09/11 14:22, Mark Brown wrote: > On Wed, Mar 09, 2011 at 01:53:38PM +0200, Mike Rapoport wrote: > >> As for me, I'd be fine with registering only the pex_clk supply and ldo0 to >> allow PCI-e on Harmony :) >> If Tegra folks are Ok with it, I'd drop the rest and we'll add more regulators >> and supplies together with drivers that use them. > > Note that there's no issue with having no supplies set for a regulator > so no reason not to register the supplies themselves, it's just the > supply map that I was flagging. I.e. having something like static struct regulator_consumer_supply tps658621_ldo7_supply[] = { }; instead of static struct regulator_consumer_supply tps658621_ldo7_supply[] = { REGULATOR_SUPPLY("avdd_hdmi", NULL), REGULATOR_SUPPLY("vdd_fuse", NULL), }; ? > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html