From: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org"
<lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
"alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org"
<alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ASoC: tegra: TrimSlice machine support
Date: Thu, 21 Apr 2011 09:53:11 +0300 [thread overview]
Message-ID: <4DAFD457.30805@compulab.co.il> (raw)
In-Reply-To: <20110418144050.GC1765-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On 04/18/11 17:40, Mark Brown wrote:
> On Sun, Apr 17, 2011 at 08:45:22AM -0700, Stephen Warren wrote:
>
>> // First line cribbed from tlv320aic3x.c.
>> // Yes, that's not the codec here, but the logic applies I think.
>> fsref = (srate % 11025 == 0) ? 44100 : 48000;
>> mclk = 256 * fsref;
>
> That's pretty much illegible due to the ternery operator and...
>
>> ... although the rate calculations in tlv320aic23.c are more complex, so
>> I could be persuaded otherwise.
>
> ...it's for a completely different CODEC with different requirements and
> features.
>
I've run several tests and the codec seems to be pretty happy when
mclk = 128 * srate
so I'd prefer to keep things simple and green :)
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2011-04-21 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 12:39 [PATCH] ASoC: tegra: TrimSlice machine support Mike Rapoport
[not found] ` <1303043988-21933-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-04-17 15:45 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF04973BB176-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-04-18 14:40 ` Mark Brown
[not found] ` <20110418144050.GC1765-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-04-18 16:16 ` Stephen Warren
2011-04-21 6:53 ` Mike Rapoport [this message]
2011-04-18 14:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAFD457.30805@compulab.co.il \
--to=mike-utxizqzc01rs1mouv/rt9w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox